Skip to content

[7.x] [Home] Adding file upload to add data page (#100863)#101166

Merged
kibanamachine merged 1 commit intoelastic:7.xfrom
kibanamachine:backport/7.x/pr-100863
Jun 2, 2021
Merged

[7.x] [Home] Adding file upload to add data page (#100863)#101166
kibanamachine merged 1 commit intoelastic:7.xfrom
kibanamachine:backport/7.x/pr-100863

Conversation

@kibanamachine
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.x:

* [Home] Adding file upload to add data page

* updating comment

* tiny refactor

* attempting to reduce bundle size

* reverting to original home register import

* lazy load tab contents

* changes based on review

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label Jun 2, 2021
@kibanamachine kibanamachine enabled auto-merge (squash) June 2, 2021 14:36
@kibanamachine
Copy link
Copy Markdown
Contributor Author

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
fileDataVisualizer 179 181 +2
home 68 70 +2
total +4

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
home 64 65 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fileDataVisualizer 1.0MB 1.0MB +695.0B
home 164.7KB 165.0KB +311.0B
total +1006.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
home 4 5 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fileDataVisualizer 11.8KB 12.7KB +934.0B
home 14.8KB 15.4KB +613.0B
total +1.5KB
Unknown metric groups

API count

id before after diff
home 88 89 +1

async chunk count

id before after diff
fileDataVisualizer 1 2 +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

@kibanamachine kibanamachine merged commit 0d855a1 into elastic:7.x Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants