Goal

Pick/define an AngularJS style guide:

• John Papa styleguide
• Todd Motto styleguide - Angular 1.4.x (more applicable to Kibana)
• Todd Motto styleguide - Angular 1.x (less applicable to Kibana)

General thoughts

1. We could take a horizontal approach of implementing the style guide. E.g. update all services, then update all directives. We could explore ways of automating this.
2. We could also take a vertical approach. This would consist of identifying discrete systems in our codebase which need refactoring/redesigning, and then applying the style guide to the new/refactored code. This overlaps a bit with Architectural problems and anti-patterns in our code. #9050.
3. We can create automated checks to enforce as many rules in the style guide as possible.
4. We can build a CLI tool, e.g. Yeoman generator or something like Angular-CI, which helps us scaffold files which follow some of these patterns and encourage consistency.