-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[APM] Refactor link helpers #83196
Copy link
Copy link
Closed
Labels
Team:APM - DEPRECATEDUse Team:obs-ux-infra_services.Use Team:obs-ux-infra_services.technical debtImprovement of the software architecture and operational architectureImprovement of the software architecture and operational architecture
Metadata
Metadata
Assignees
Labels
Team:APM - DEPRECATEDUse Team:obs-ux-infra_services.Use Team:obs-ux-infra_services.technical debtImprovement of the software architecture and operational architectureImprovement of the software architecture and operational architecture
Type
Fields
Give feedbackNo fields configured for issues without a type.
As mentioned in the discussion on #82870, some of the link components in shared/Links/apm/ are no longer being used, but hooks that call
useAPMHrefnow being used and are contained in those files in order to keep logic for constructing links located together.In general, having components that render wrapped
EuiLinkcomponents can be less useful, as demonstrated by the PR mentioned above: Using anEuiLinkinside of anEuiTabcauses problems with keyboard focus.EuiTabtakes anhrefprop, which is the only thing we need.The links and hooks are differentiated by which filters need to be persisted between navigation, so it still makes sense to have different hooks for different locations.
We could possibly make one hooks file that exports multiple hooks and replace the use of the link components.