Skip to content

[APM] Refactor link helpers #83196

@smith

Description

@smith

As mentioned in the discussion on #82870, some of the link components in shared/Links/apm/ are no longer being used, but hooks that call useAPMHref now being used and are contained in those files in order to keep logic for constructing links located together.

In general, having components that render wrapped EuiLink components can be less useful, as demonstrated by the PR mentioned above: Using an EuiLink inside of an EuiTab causes problems with keyboard focus. EuiTab takes an href prop, which is the only thing we need.

The links and hooks are differentiated by which filters need to be persisted between navigation, so it still makes sense to have different hooks for different locations.

We could possibly make one hooks file that exports multiple hooks and replace the use of the link components.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Team:APM - DEPRECATEDUse Team:obs-ux-infra_services.technical debtImprovement of the software architecture and operational architecture

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions