-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[TSVB] use new Search API for rollup search #82710
Copy link
Copy link
Closed
Labels
Feature:TSVBTSVB (Time Series Visual Builder)TSVB (Time Series Visual Builder)Team:VisualizationsTeam label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t//Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t//technical debtImprovement of the software architecture and operational architectureImprovement of the software architecture and operational architecture
Metadata
Metadata
Assignees
Labels
Feature:TSVBTSVB (Time Series Visual Builder)TSVB (Time Series Visual Builder)Team:VisualizationsTeam label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t//Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t//technical debtImprovement of the software architecture and operational architectureImprovement of the software architecture and operational architecture
Type
Fields
Give feedbackNo fields configured for issues without a type.
Historically, the code related to the rollup search in
TSVBwas added to thex-pack/rollupplugin. And now the rollup plugin has a folder specific only toTSVB(seex-pack/plugins/rollup/server/lib/search_strategies)IMO, this is a design issue because usually a
TSVBplugin should depend on aRollupplugin, but not vice versa.On the other hand, in #76274, we started using a new
Search APIthat natively supports search by rollup data.I think we should:
x-pack/plugins/rollup/server/lib/search_strategiesand which can be reused from the data pluginvis_type_timeseries_enhancedplugin and move into it related codeSearch APIfor searching byRollupdata