-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Security Solution][Detections] Updating prepackaged rules overwrites existing exceptions #80417
Copy link
Copy link
Closed
Labels
Feature:Detection RulesSecurity Solution rules and Detection EngineSecurity Solution rules and Detection EngineTeam: SecuritySolutionSecurity Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.Team:Detections and RespSecurity Detection Response TeamSecurity Detection Response TeamTeam:SIEMbugFixes for quality problems that affect the customer experienceFixes for quality problems that affect the customer experiencefixedimpact:highAddressing this issue will have a high level of impact on the quality/strength of our product.Addressing this issue will have a high level of impact on the quality/strength of our product.v7.10.0
Metadata
Metadata
Assignees
Labels
Feature:Detection RulesSecurity Solution rules and Detection EngineSecurity Solution rules and Detection EngineTeam: SecuritySolutionSecurity Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.Team:Detections and RespSecurity Detection Response TeamSecurity Detection Response TeamTeam:SIEMbugFixes for quality problems that affect the customer experienceFixes for quality problems that affect the customer experiencefixedimpact:highAddressing this issue will have a high level of impact on the quality/strength of our product.Addressing this issue will have a high level of impact on the quality/strength of our product.v7.10.0
Type
Fields
Give feedbackNo fields configured for issues without a type.
Kibana version:
7.9
When updating prepackaged rules any existing exceptions on the rules being updated will be overridden with whatever exceptions are on the prepackaged rules. To mitigate this, we can merge any existing
exceptions_listitems from therulesFromFileSystemwith those coming from theprepackagedRules.Flow:
Get rules to update:
kibana/x-pack/plugins/security_solution/server/lib/detection_engine/routes/rules/add_prepackaged_rules_route.ts
Line 65 in 21156d6
Add logic for merging existing exceptions
kibana/x-pack/plugins/security_solution/server/lib/detection_engine/routes/rules/add_prepackaged_rules_route.ts
Line 87 in 21156d6
Patch in
update_prepacked_rules.tswill now include any pre-existing exceptions and will no longer overwrite:kibana/x-pack/plugins/security_solution/server/lib/detection_engine/rules/update_prepacked_rules.ts
Line 63 in d6c7128
Steps to recreate: