Skip to content

[Canvas] Compressed form clean-up #45904

@ryankeairns

Description

@ryankeairns

The compressed EUI form inputs have been redesigned which has resulted in some small visual design 'breaks' and new opportunities to improve our form layouts.

Since each element has its own sidebar, let's attempt to divide the work up by element (listed below). There are two steps to cleaning up each Canvas element:

  1. follow The checklist from the Meta cleanup issue (copy/paste it into your PR) and
  2. look for places where compressed form inputs should be used, but where they are currently not being used.

At a future time, a larger redesign of the Canvas sidebar forms is loosely planned where we'll look at making all panels visible by default. This is referring to the settings/options that are behind the 'plus in circle' icon buttons (like CSS and Container styles). It's worth noting that these panels do still need to be cleaned up in this initial effort.

As you work on an element, place your name next to it and add the PR link once it is ready for review


Please copy and paste this into your PRs

PR checklist

  • Form control and row properly uses the compressed property.
  • Fixed any EuiFormRow sibling spacing issues.
  • Fixed any compressed EuiFormRow children that didn't also have the compressed prop.
  • Changed EuiFormRow compressed to display="compressed"
  • Changed EuiFormRow displayOnly to display="center" or display="centerCompressed"
  • Fixed any EuiFormLabel sibling spacing issues
  • Fixed any EuiFilePicker compressed issues

Metadata

Metadata

Labels

Feature:CanvasTeam:PresentationPresentation Team for Dashboard, Input Controls, and Canvas t//designimpact:highAddressing this issue will have a high level of impact on the quality/strength of our product.loe:mediumMedium Level of Effortrelease_note:skipSkip the PR/issue when compiling release notes

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions