-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New numeral field formatter #39211
Copy link
Copy link
Closed
Labels
Feature:FieldFormattersTeam:DataDiscoveryDiscover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t//Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t//enhancementNew value added to drive a business resultNew value added to drive a business resultimpact:mediumAddressing this issue will have a medium level of impact on the quality/strength of our product.Addressing this issue will have a medium level of impact on the quality/strength of our product.loe:smallSmall Level of EffortSmall Level of Effort
Metadata
Metadata
Assignees
Labels
Feature:FieldFormattersTeam:DataDiscoveryDiscover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t//Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t//enhancementNew value added to drive a business resultNew value added to drive a business resultimpact:mediumAddressing this issue will have a medium level of impact on the quality/strength of our product.Addressing this issue will have a medium level of impact on the quality/strength of our product.loe:smallSmall Level of EffortSmall Level of Effort
Type
Fields
Give feedbackNo fields configured for issues without a type.
The numeral field formatter that currently exists in Kibana makes heavy use of numeral.js and the numeral.js format strings. Those are not very intuitive to users and we often see that there are several misunderstandings around then, e.g. that the period and comma inside the string do not actually represent whether you want to use a comma or period as thousand separator, but where it's placed. Also it only allows one locale to be used per Space, making it impossible to use different number locales on different index patterns or fields. The following comment has more issues listed.
Same as for currencies (#25993) we should create a new better numeral field formatter.
The numeral field formatter should allow you to select the following configuration parameters:
We should have some common templates to preselect at least the first two in that list with e.g. US numberal format, or other common formats used.
Since the Numer.js library is pretty much dead right now (and we're already maintaining a separate fork), it would be good if we would try not to use it anymore.
Since the currency is just a prefix/suffix to the number, maybe we don't want to build the separate currency field formatter (#25993) but instead merge both into one.