-
Notifications
You must be signed in to change notification settings - Fork 8.6k
Remove Angular from i18n framework #37851
Copy link
Copy link
Closed
Labels
Project:i18nTeam:CorePlatform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t//Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t//enhancementNew value added to drive a business resultNew value added to drive a business resultv7.16.0
Metadata
Metadata
Assignees
Labels
Project:i18nTeam:CorePlatform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t//Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t//enhancementNew value added to drive a business resultNew value added to drive a business resultv7.16.0
Type
Fields
Give feedbackNo fields configured for issues without a type.
Blocked by #109791
Part of #105711
Update Since our plan to remove Angular until 7.16 completely I repurpose that issue to remove all Angular code from the i18n framework.
After getting feedback across Kibana, and our plan to eventually move out of angular, ideally we'd want to get rid angular specific i18n code. Namely injecting i18n in controllers/providers/services, i18n filter and i18n directive.
I ran some numbers and we currently have the following i18n count in angular:
i18n-*): 891Initially for the short term I am thinking we can get rid of angular i18n filters and providers. (356 total locations).
Restricting angular specific i18n to directives. Only allowing i18n in angular html in the following format:
We can get rid of the i18n angular directive (
i18n-*) whenever all angular html is converted into react components (long term).Context #27968
CC @azasypkin