Skip to content

[Embeddable Rebuild] Make HasSupportedTriggers optional for drilldown actions #202054

@Heenawter

Description

@Heenawter

Describe the feature:
Currently, we require supportedTriggers() to be defined in both the create and edit drilldown actions in order for them to be compatible. This is overkill IMO, because it's possible for drilldowns to only be supported via the context menu, which is already provided as a default:

const triggers = [
...ensureNestedTriggers(embeddable.supportedTriggers()),
CONTEXT_MENU_TRIGGER,
];

Because it's required, embeddables that don't need other supported triggers are forced to return an empty array in order to have context menu drilldowns. See #201870 (comment) for more context.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Feature:DashboardDashboard related featuresTeam:PresentationPresentation Team for Dashboard, Input Controls, and Canvas t//impact:lowAddressing this issue will have a low level of impact on the quality/strength of our product.loe:smallSmall Level of Effortproject:embeddableRebuild

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions