-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[Security Solution] Rules mistakenly marked as customized #199629
Copy link
Copy link
Labels
8.17 candidateFeature:Prebuilt Detection RulesSecurity Solution Prebuilt Detection Rules areaSecurity Solution Prebuilt Detection Rules areaTeam: SecuritySolutionSecurity Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.Team:Detection Rule ManagementSecurity Detection Rule Management TeamSecurity Detection Rule Management TeamTeam:Detections and RespSecurity Detection Response TeamSecurity Detection Response TeambugFixes for quality problems that affect the customer experienceFixes for quality problems that affect the customer experienceimpact:highAddressing this issue will have a high level of impact on the quality/strength of our product.Addressing this issue will have a high level of impact on the quality/strength of our product.v8.16.1v8.17.0v9.0.0
Metadata
Metadata
Assignees
Labels
8.17 candidateFeature:Prebuilt Detection RulesSecurity Solution Prebuilt Detection Rules areaSecurity Solution Prebuilt Detection Rules areaTeam: SecuritySolutionSecurity Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.Team:Detection Rule ManagementSecurity Detection Rule Management TeamSecurity Detection Rule Management TeamTeam:Detections and RespSecurity Detection Response TeamSecurity Detection Response TeambugFixes for quality problems that affect the customer experienceFixes for quality problems that affect the customer experienceimpact:highAddressing this issue will have a high level of impact on the quality/strength of our product.Addressing this issue will have a high level of impact on the quality/strength of our product.v8.16.1v8.17.0v9.0.0
Type
Fields
Give feedbackNo fields configured for Bug.
Summary
A prebuilt rule is marked as customized when an action is attached to it. The diff algorithm incorrectly detects changes to the
threatandrule_schedulefields.Steps to Reproduce
Expected Result
Since adding or changing rule actions should not mark rules as customized, the returned rule should have
rule_source.is_customized = false.Actual Result
The rule is incorrectly marked as customized.
Initial Analysis
The rule asset object and installed rule saved object have some values represented in different formats, leading to mismatches. The differences include:
rule_scheduleis in minutes (e.g.,4m) in one case and seconds (e.g.,240s) in another.threatmay omit optional fields, such assubtechnique, in the rule asset object, whereas the rule saved object has them as empty arrays (e.g.,subtechnique: []).Other fields may also have similar format differences. To address this, the diff algorithm should:
This ensures consistency in identifying rule changes.