-
Notifications
You must be signed in to change notification settings - Fork 8.6k
Fix and refactor "No results" screen for visualizations #16640
Copy link
Copy link
Closed
Labels
Feature:VisualizationsGeneric visualization features (in case no more specific feature label is available)Generic visualization features (in case no more specific feature label is available)Team:VisualizationsTeam label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t//Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t//
Metadata
Metadata
Assignees
Labels
Feature:VisualizationsGeneric visualization features (in case no more specific feature label is available)Generic visualization features (in case no more specific feature label is available)Team:VisualizationsTeam label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t//Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t//
Type
Fields
Give feedbackNo fields configured for issues without a type.
The "No results" screen, that should be shown for visualizations, if no data has been found, requires some refactoring and fixing.
There are currently two implementations - one for vislib visualizations and one in
<visualization>for all visualizations. The later doesn't work properly. We should at least fix the following issues:<visualization>only works if there is no response handler. Instead the response handler should tell us if there has been results.vis.params.handleNoResultscheck. This isn't used anywhere.I think a visualization type should still be able to specify whether it wants to handle no data scenario itself or want Kibana to show the default message.
This would also fix #16420