Skip to content

Fix and refactor "No results" screen for visualizations #16640

@timroes

Description

@timroes

The "No results" screen, that should be shown for visualizations, if no data has been found, requires some refactoring and fixing.

There are currently two implementations - one for vislib visualizations and one in <visualization> for all visualizations. The later doesn't work properly. We should at least fix the following issues:

  • Only have one implementation, not two
  • <visualization> only works if there is no response handler. Instead the response handler should tell us if there has been results.
  • Remove the dead vis.params.handleNoResults check. This isn't used anywhere.

I think a visualization type should still be able to specify whether it wants to handle no data scenario itself or want Kibana to show the default message.

This would also fix #16420

Metadata

Metadata

Assignees

No one assigned

    Labels

    Feature:VisualizationsGeneric visualization features (in case no more specific feature label is available)Team:VisualizationsTeam label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t//

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions