-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[Dashboard Navigation] Fix delayed opening of create/edit flyout #161693
Copy link
Copy link
Closed
Labels
Project:Dashboard NavigationRelated to the Dashboard Navigation ProjectRelated to the Dashboard Navigation ProjectTeam:PresentationPresentation Team for Dashboard, Input Controls, and Canvas t//Presentation Team for Dashboard, Input Controls, and Canvas t//bugFixes for quality problems that affect the customer experienceFixes for quality problems that affect the customer experienceimpact:mediumAddressing this issue will have a medium level of impact on the quality/strength of our product.Addressing this issue will have a medium level of impact on the quality/strength of our product.loe:smallSmall Level of EffortSmall Level of Effort
Metadata
Metadata
Assignees
Labels
Project:Dashboard NavigationRelated to the Dashboard Navigation ProjectRelated to the Dashboard Navigation ProjectTeam:PresentationPresentation Team for Dashboard, Input Controls, and Canvas t//Presentation Team for Dashboard, Input Controls, and Canvas t//bugFixes for quality problems that affect the customer experienceFixes for quality problems that affect the customer experienceimpact:mediumAddressing this issue will have a medium level of impact on the quality/strength of our product.Addressing this issue will have a medium level of impact on the quality/strength of our product.loe:smallSmall Level of EffortSmall Level of Effort
Type
Fields
Give feedbackNo fields configured for issues without a type.
Describe the bug:
When the network is throttled, the navigation embeddable edit flyout is delayed by some sort of async behaviour happening internally - even if we are waiting for something to load, this should not stop the flyout from opening. FYI the image embeddable suffers from the same thing (we don't need to fix this) - so maybe it has something to do with how we are opening the flyout in
getExplicitInput(since we took inspo from the image embeddable for this)? Need to investigateVideo:
Screen.Recording.2023-07-11.at.11.39.08.AM.mov
Notice that the image "pops in" for the empty state even on the second load, most likely because we are importing it in the flyout itself - as part of this, we should probably make it so that this is only loaded/imported a single time.