Skip to content

[Dashboard][Canvas] Await IsEditable #121003

@ThomThomson

Description

@ThomThomson

Describe the bug: the embeddable isEditable function is marked async, but its usages in src/plugins/dashboard/public/application/top_nav/editor_menu.tsx and x-pack/plugins/canvas/public/components/workpad_header/editor_menu/editor_menu.tsx are not awaited. This means that potentially embeddables that the user doesn't have permission for could show up in the list.

Thanks to @brianseeders for catching this in #120812

Metadata

Metadata

Assignees

Labels

Feature:CanvasFeature:DashboardDashboard related featuresTeam:PresentationPresentation Team for Dashboard, Input Controls, and Canvas t//bugFixes for quality problems that affect the customer experienceimpact:mediumAddressing this issue will have a medium level of impact on the quality/strength of our product.loe:smallSmall Level of Effort

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions