-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[Dashboard][Canvas] Await IsEditable #121003
Copy link
Copy link
Closed
Labels
Feature:CanvasFeature:DashboardDashboard related featuresDashboard related featuresTeam:PresentationPresentation Team for Dashboard, Input Controls, and Canvas t//Presentation Team for Dashboard, Input Controls, and Canvas t//bugFixes for quality problems that affect the customer experienceFixes for quality problems that affect the customer experienceimpact:mediumAddressing this issue will have a medium level of impact on the quality/strength of our product.Addressing this issue will have a medium level of impact on the quality/strength of our product.loe:smallSmall Level of EffortSmall Level of Effort
Metadata
Metadata
Assignees
Labels
Feature:CanvasFeature:DashboardDashboard related featuresDashboard related featuresTeam:PresentationPresentation Team for Dashboard, Input Controls, and Canvas t//Presentation Team for Dashboard, Input Controls, and Canvas t//bugFixes for quality problems that affect the customer experienceFixes for quality problems that affect the customer experienceimpact:mediumAddressing this issue will have a medium level of impact on the quality/strength of our product.Addressing this issue will have a medium level of impact on the quality/strength of our product.loe:smallSmall Level of EffortSmall Level of Effort
Type
Fields
Give feedbackNo fields configured for issues without a type.
Describe the bug: the embeddable
isEditablefunction is marked async, but its usages insrc/plugins/dashboard/public/application/top_nav/editor_menu.tsxandx-pack/plugins/canvas/public/components/workpad_header/editor_menu/editor_menu.tsxare not awaited. This means that potentially embeddables that the user doesn't have permission for could show up in the list.Thanks to @brianseeders for catching this in #120812