Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: elastic/kibana
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 07bea5ba8
Choose a base ref
...
head repository: elastic/kibana
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 70aa11a~
Choose a head ref
  • 14 commits
  • 67 files changed
  • 1 contributor

Commits on Apr 16, 2020

  1. Move misc. config into NP folder 

    A few of these were moved into the cypress folder as they're
cypress-specific.

I tried to update all the relative paths but some are likely broken. I'm
not going to know until other stuff is fixed, though.
    @rylnd
    rylnd committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    f24c1db View commit details
    Browse the repository at this point in the history

  2. Move value for siem index pattern into common/constants 

    The other default values live in there, this is no different.
    @rylnd
    rylnd committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    1b36855 View commit details
    Browse the repository at this point in the history

  3. Update paths following file move 

    If this was referencing the full project, it now references both paths
(legacy for UI, and NP for server).
    @rylnd
    rylnd committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    e528bea View commit details
    Browse the repository at this point in the history

  4. Replace Legacy Config with NP Config 

    * Updates plugin to use NP config
  * defines new config previously coming from savedObjects config
* cleans up legacy types

 Conflicts:
	x-pack/plugins/siem/server/lib/detection_engine/routes/rules/export_rules_route.ts
	x-pack/plugins/siem/server/lib/detection_engine/routes/rules/import_rules_route.ts
	x-pack/plugins/siem/server/lib/detection_engine/rules/types.ts
	x-pack/plugins/siem/server/plugin.ts
	x-pack/plugins/siem/server/routes/index.ts
	x-pack/plugins/siem/server/types.ts
    @rylnd
    rylnd committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    7faeeed View commit details
    Browse the repository at this point in the history

  5. Remove local SIEM tsconfig 

    This was originally added to address an issue with tsserver, but that
issue is no longer relevant. The presence of this file confuses
typescript into thinking that siem is a separate TS project.
    @rylnd
    rylnd committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    c3c487f View commit details
    Browse the repository at this point in the history

  6. Update kibana.json to declare our dependencies 

    These are not necessarily correct in terms of what's required/optional,
but this is what's declared in our types.
    @rylnd
    rylnd committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    faa3d93 View commit details
    Browse the repository at this point in the history

  7. Remove legacy plugin instantiation 

    * Removes legacy instantiation of server plugin, which is now handled by
NP
* Loosens legacy config spec so we no longer have to duplicate config
types
    @rylnd
    rylnd committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    3b66124 View commit details
    Browse the repository at this point in the history

  8. Update tests with NP config 

    These were written against the old Hapi config function; now, we just
have a POJO.
    @rylnd
    rylnd committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    6030b1b View commit details
    Browse the repository at this point in the history

  9. Update es_archiver helpers' paths 

    I'm not quite sure if these are working yet, but they're no longer
throwing errors.
    @rylnd
    rylnd committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    c4ceebb View commit details
    Browse the repository at this point in the history

  10. Ignore restricted path on script 

    This was cribbed from infra, who has made a similar change.
    @rylnd
    rylnd committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    c6cdbc2 View commit details
    Browse the repository at this point in the history

  11. Ignore restricted path on temporary savedObject mappings import 

    This will be changed subsequently when we switch to the NP form of
savedObject type registration.
    @rylnd
    rylnd committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    06c62cf View commit details
    Browse the repository at this point in the history

  12. Add symlink to lockfile

    @rylnd
    rylnd committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    b36cdf3 View commit details
    Browse the repository at this point in the history

  13. Fix paths on circular deps script

    @rylnd
    rylnd committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    a8f272b View commit details
    Browse the repository at this point in the history

  14. Add separate config for Rule and Timeline saved objects 

    We had previously used the savedObjects' config, but those are not
currently exposed to us on New Platform. For now, we're going to split
this into two sets of values for the SOs we deal with
importing/exporting within the SIEM app, with the same defaults as
savedObjects.
    @rylnd
    rylnd committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    6b09a1f View commit details
    Browse the repository at this point in the history
Loading