Enable exhaustive-deps; correct any lint warnings (#68453)

clintandrewhall · elasticmachine · clintandrewhall · commit ffe6ac1a6f23 · 2020-06-10T12:18:19.000-05:00
Co-authored-by: Elastic Machine &lt;elasticmachine@users.noreply.github.com&gt;
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -97,7 +97,6 @@ module.exports = {
     {
       files: ['x-pack/plugins/canvas/**/*.{js,ts,tsx}'],
       rules: {
-        'react-hooks/exhaustive-deps': 'off',
         'jsx-a11y/click-events-have-key-events': 'off',
       },
     },
diff --git a/x-pack/plugins/canvas/public/apps/workpad/workpad_app/workpad_telemetry.tsx b/x-pack/plugins/canvas/public/apps/workpad/workpad_app/workpad_telemetry.tsx
@@ -69,6 +69,7 @@ export const withUnconnectedElementsLoadedTelemetry = <P extends {}>(
 ) =>
   function ElementsLoadedTelemetry(props: ElementsLoadedTelemetryProps) {
     const { telemetryElementCounts, workpad, telemetryResolvedArgs, ...other } = props;
+    const { error, pending } = telemetryElementCounts;
 
     const [currentWorkpadId, setWorkpadId] = useState<string | undefined>(undefined);
     const [hasReported, setHasReported] = useState(false);
@@ -87,27 +88,20 @@ export const withUnconnectedElementsLoadedTelemetry = <P extends {}>(
           0
         );
 
-        if (
-          workpadElementCount === 0 ||
-          (resolvedArgsAreForWorkpad && telemetryElementCounts.pending === 0)
-        ) {
+        if (workpadElementCount === 0 || (resolvedArgsAreForWorkpad && pending === 0)) {
           setHasReported(true);
         } else {
           setHasReported(false);
         }
-      } else if (
-        !hasReported &&
-        telemetryElementCounts.pending === 0 &&
-        resolvedArgsAreForWorkpad
-      ) {
-        if (telemetryElementCounts.error > 0) {
+      } else if (!hasReported && pending === 0 && resolvedArgsAreForWorkpad) {
+        if (error > 0) {
           trackMetric(METRIC_TYPE.LOADED, [WorkpadLoadedMetric, WorkpadLoadedWithErrorsMetric]);
         } else {
           trackMetric(METRIC_TYPE.LOADED, WorkpadLoadedMetric);
         }
         setHasReported(true);
       }
-    });
+    }, [currentWorkpadId, hasReported, error, pending, telemetryResolvedArgs, workpad]);
 
     return <Component {...(other as P)} workpad={workpad} />;
   };

Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,6 @@ module.exports = {`
`97`	`97`	`{`
`98`	`98`	`files: ['x-pack/plugins/canvas/*/.{js,ts,tsx}'],`
`99`	`99`	`rules: {`
`100`		`- 'react-hooks/exhaustive-deps': 'off',`
`101`	`100`	`'jsx-a11y/click-events-have-key-events': 'off',`
`102`	`101`	`},`
`103`	`102`	`},`