Mark timefield error as user error

doakalexi · doakalexi · commit fb61847fcf67 · 2025-07-02T09:13:43.000-07:00
diff --git a/x-pack/platform/plugins/shared/stack_alerts/server/rule_types/es_query/lib/fetch_search_source_query.test.ts b/x-pack/platform/plugins/shared/stack_alerts/server/rule_types/es_query/lib/fetch_search_source_query.test.ts
@@ -659,6 +659,27 @@ describe('fetchSearchSourceQuery', () => {
       }
     });
 
+    it('should throw user error if data view does not have a timefield', async () => {
+      try {
+        const dataView = createDataView();
+        dataView.timeFieldName = undefined;
+        const searchSourceInstance = createSearchSourceMock({ index: dataView });
+
+        await updateSearchSource(
+          searchSourceInstance,
+          dataView,
+          defaultParams,
+          '2020-01-09T22:12:41.941Z',
+          new Date().toISOString(),
+          new Date().toISOString(),
+          logger
+        );
+      } catch (err) {
+        expect(getErrorSource(err)).toBe(TaskErrorSource.USER);
+        expect(err.message).toBe('Data view with ID test-id no longer contains a time field.');
+      }
+    });
+
     it('should re-throw error for generic errors', async () => {
       searchSourceCommonMock.createLazy.mockImplementationOnce(() => {
         throw new Error('fail');
diff --git a/x-pack/platform/plugins/shared/stack_alerts/server/rule_types/es_query/lib/fetch_search_source_query.ts b/x-pack/platform/plugins/shared/stack_alerts/server/rule_types/es_query/lib/fetch_search_source_query.ts
@@ -140,7 +140,10 @@ export async function updateSearchSource(
   const timeField = await index.getTimeField();
 
   if (!timeField) {
-    throw new Error(`Data view with ID ${index.id} no longer contains a time field.`);
+    throw createTaskRunError(
+      new Error(`Data view with ID ${index.id} no longer contains a time field.`),
+      TaskErrorSource.USER
+    );
   }
 
   searchSource.setField('size', isGroupAgg ? 0 : params.size);
