cleanup

stephmilovic · stephmilovic · commit f9469c626e73 · 2020-05-28T17:27:56.000-06:00
diff --git a/x-pack/plugins/siem/public/alerts/components/signals/index.tsx b/x-pack/plugins/siem/public/alerts/components/signals/index.tsx
@@ -270,13 +270,6 @@ export const SignalsTableComponent: React.FC<SignalsTableComponentProps> = ({
     }
   }, [defaultFilters, filterGroup]);
   const { initializeTimeline, setTimelineActions } = useManageTimeline();
-  useEffect(() => {
-    setTimelineActions({
-      id: SIGNALS_PAGE_TIMELINE_ID,
-      queryFields: requiredFieldsForActions,
-      timelineActions: additionalActions,
-    });
-  }, [additionalActions]);
 
   useEffect(() => {
     initializeTimeline({
@@ -287,7 +280,14 @@ export const SignalsTableComponent: React.FC<SignalsTableComponentProps> = ({
       title: i18n.SIGNALS_TABLE_TITLE,
       selectAll: canUserCRUD ? selectAll : false,
     });
-  }, [canUserCRUD, selectAll]);
+  }, []);
+  useEffect(() => {
+    setTimelineActions({
+      id: SIGNALS_PAGE_TIMELINE_ID,
+      queryFields: requiredFieldsForActions,
+      timelineActions: additionalActions,
+    });
+  }, [additionalActions]);
   const headerFilterGroup = useMemo(
     () => <SignalsTableFilterGroup onFilterGroupChanged={onFilterGroupChangedCallback} />,
     [onFilterGroupChangedCallback]
diff --git a/x-pack/plugins/siem/public/common/components/alerts_viewer/alerts_table.tsx b/x-pack/plugins/siem/public/common/components/alerts_viewer/alerts_table.tsx
@@ -4,12 +4,13 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-import React, { useMemo } from 'react';
+import React, { useEffect, useMemo } from 'react';
 
 import { Filter } from '../../../../../../../src/plugins/data/public';
 import { StatefulEventsViewer } from '../events_viewer';
 import { alertsDefaultModel } from './default_headers';
-
+import { useManageTimeline } from '../../../timelines/components/manage_timeline';
+import * as i18n from './translations';
 export interface OwnProps {
   end: number;
   id: string;
@@ -58,6 +59,17 @@ interface Props {
 
 const AlertsTableComponent: React.FC<Props> = ({ endDate, startDate, pageFilters = [] }) => {
   const alertsFilter = useMemo(() => [...defaultAlertsFilters, ...pageFilters], [pageFilters]);
+  const { initializeTimeline } = useManageTimeline();
+
+  useEffect(() => {
+    initializeTimeline({
+      id: ALERTS_TABLE_ID,
+      documentType: i18n.ALERTS_DOCUMENT_TYPE,
+      footerText: i18n.TOTAL_COUNT_OF_ALERTS,
+      title: i18n.ALERTS_TABLE_TITLE,
+      unit: i18n.UNIT,
+    });
+  }, []);
   return (
     <StatefulEventsViewer
       pageFilters={alertsFilter}
diff --git a/x-pack/plugins/siem/public/timelines/components/timeline/footer/index.tsx b/x-pack/plugins/siem/public/timelines/components/timeline/footer/index.tsx
@@ -28,7 +28,7 @@ import { OnChangeItemsPerPage, OnLoadMore } from '../events';
 import { LastUpdatedAt } from './last_updated';
 import * as i18n from './translations';
 import { useEventDetailsWidthContext } from '../../../../common/components/events_viewer/event_details_width_context';
-import { useManageTimeline, TimelineTypeContext } from '../../manage_timeline';
+import { useManageTimeline } from '../../manage_timeline';
 
 export const isCompactFooter = (width: number): boolean => width < 600;
 
diff --git a/x-pack/plugins/siem/public/timelines/components/timeline/timeline_context.tsx b/x-pack/plugins/siem/public/timelines/components/timeline/timeline_context.tsx
