Skip to content

Commit f8a2e67

Browse files
misticmistic
committed
Merge remote-tracking branch 'upstream/master' into integrate-build-buddy-with-our-bazel-setup
2 parents cc503f8 + 0c5fb85 commit f8a2e67

84 files changed

Lines changed: 1649 additions & 475 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎docs/development/core/public/kibana-plugin-core-public.doclinksstart.links.md‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ readonly links: {
2121
readonly installation: string;
2222
readonly configuration: string;
2323
readonly elasticsearchOutput: string;
24+
readonly elasticsearchModule: string;
2425
readonly startup: string;
2526
readonly exportedFields: string;
2627
};
@@ -29,6 +30,10 @@ readonly links: {
2930
};
3031
readonly metricbeat: {
3132
readonly base: string;
33+
readonly configure: string;
34+
readonly httpEndpoint: string;
35+
readonly install: string;
36+
readonly start: string;
3237
};
3338
readonly enterpriseSearch: {
3439
readonly base: string;

‎docs/maps/connect-to-ems.asciidoc‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ endif::[]
8686

8787
[cols="2*<"]
8888
|===
89-
| [[ems-hostname]]`hostname`
89+
| [[ems-host]]`host`
9090
| Specifies the host of the backend server. To allow remote users to connect, set the value to the IP address or DNS name of the {hosted-ems} container. *Default: _your-hostname_*. <<server-host,Equivalent {kib} setting>>.
9191

9292
| `port`
@@ -199,7 +199,7 @@ TIP: The available basemaps and boundaries can be explored from the `/maps` endp
199199
[[elastic-maps-server-kibana]]
200200
==== Kibana configuration
201201

202-
With {hosted-ems} running, add the `map.emsUrl` configuration key in your <<settings, kibana.yml>> file pointing to the root of the service. This setting will point {kib} to request EMS basemaps and boundaries from {hosted-ems}. Typically this will be the URL to the <<ems-hostname,hostname and port>> of {hosted-ems}. For example, `map.emsUrl: https://my-ems-server:8080`.
202+
With {hosted-ems} running, add the `map.emsUrl` configuration key in your <<settings, kibana.yml>> file pointing to the root of the service. This setting will point {kib} to request EMS basemaps and boundaries from {hosted-ems}. Typically this will be the URL to the <<ems-host,host and port>> of {hosted-ems}. For example, `map.emsUrl: https://my-ems-server:8080`.
203203

204204

205205
[float]

‎docs/maps/maps-aggregations.asciidoc‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,9 +68,9 @@ To enable a blended layer that dynamically shows clusters or documents:
6868

6969
[role="xpack"]
7070
[[maps-top-hits-aggregation]]
71-
=== Top hits per entity
71+
=== Display the most relevant documents per entity
7272

73-
You can display the most relevant documents per entity, for example, the most recent GPS tracks per flight.
73+
Use *Top hits per entity* to display the most relevant documents per entity, for example, the most recent GPS tracks per flight route.
7474
To get this data, {es} first groups your data using a {ref}/search-aggregations-bucket-terms-aggregation.html[terms aggregation],
7575
then accumulates the most relevant documents based on sort order for each entry using a {ref}/search-aggregations-metrics-top-hits-aggregation.html[top hits metric aggregation].
7676

‎docs/setup/install/deb.asciidoc‎

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,8 @@ The Debian package for Kibana can be <<install-deb,downloaded from our website>>
88
or from our <<deb-repo,APT repository>>. It can be used to install
99
Kibana on any Debian-based system such as Debian and Ubuntu.
1010

11-
This package is free to use under the Elastic license. It contains open source
12-
and free commercial features and access to paid commercial features.
13-
<<managing-licenses,Start a 30-day trial>> to try out all of the
14-
paid commercial features. See the
15-
https://www.elastic.co/subscriptions[Subscriptions] page for information about
16-
Elastic license levels.
11+
This package contains both free and subscription features.
12+
<<managing-licenses,Start a 30-day trial>> to try out all of the features.
1713

1814
The latest stable version of Kibana can be found on the
1915
link:/downloads/kibana[Download Kibana] page. Other versions can

‎docs/setup/install/rpm.asciidoc‎

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,8 @@ and Oracle Enterprise.
1313
NOTE: RPM install is not supported on distributions with old versions of RPM,
1414
such as SLES 11 and CentOS 5. Please see <<targz>> instead.
1515

16-
This package is free to use under the Elastic license. It contains open source
17-
and free commercial features and access to paid commercial features.
18-
<<managing-licenses,Start a 30-day trial>> to try out all of the
19-
paid commercial features. See the
20-
https://www.elastic.co/subscriptions[Subscriptions] page for information about
21-
Elastic license levels.
16+
This package contains both free and subscription features.
17+
<<managing-licenses,Start a 30-day trial>> to try out all of the features.
2218

2319
The latest stable version of Kibana can be found on the
2420
link:/downloads/kibana[Download Kibana] page. Other versions can

‎docs/setup/install/targz.asciidoc‎

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,8 @@
77
Kibana is provided for Linux and Darwin as a `.tar.gz` package. These packages
88
are the easiest formats to use when trying out Kibana.
99

10-
These packages are free to use under the Elastic license. They contain open
11-
source and free commercial features and access to paid commercial features.
12-
<<managing-licenses,Start a 30-day trial>> to try out all of the
13-
paid commercial features. See the
14-
https://www.elastic.co/subscriptions[Subscriptions] page for information about
15-
Elastic license levels.
10+
This package contains both free and subscription features.
11+
<<managing-licenses,Start a 30-day trial>> to try out all of the features.
1612

1713
The latest stable version of Kibana can be found on the
1814
link:/downloads/kibana[Download Kibana] page.

‎docs/setup/install/windows.asciidoc‎

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,8 @@
66

77
Kibana can be installed on Windows using the `.zip` package.
88

9-
This package is free to use under the Elastic license. It contains open source
10-
and free commercial features and access to paid commercial features.
11-
<<managing-licenses,Start a 30-day trial>> to try out all of the
12-
paid commercial features. See the
13-
https://www.elastic.co/subscriptions[Subscriptions] page for information about
14-
Elastic license levels.
9+
This package contains both free and subscription features.
10+
<<managing-licenses,Start a 30-day trial>> to try out all of the features.
1511

1612
The latest stable version of Kibana can be found on the
1713
link:/downloads/kibana[Download Kibana] page.

‎packages/kbn-legacy-logging/src/utils/get_payload_size.test.ts‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
* Side Public License, v 1.
77
*/
88

9+
import { createGunzip } from 'zlib';
910
import mockFs from 'mock-fs';
1011
import { createReadStream } from 'fs';
1112

@@ -54,6 +55,11 @@ describe('getPayloadSize', () => {
5455
const result = getResponsePayloadBytes(readStream);
5556
expect(result).toBe(Buffer.byteLength(data));
5657
});
58+
59+
test('ignores streams that are not instances of ReadStream', async () => {
60+
const result = getResponsePayloadBytes(createGunzip());
61+
expect(result).toBe(undefined);
62+
});
5763
});
5864

5965
describe('handles plain responses', () => {
@@ -72,6 +78,11 @@ describe('getPayloadSize', () => {
7278
const result = getResponsePayloadBytes(payload);
7379
expect(result).toBe(JSON.stringify(payload).length);
7480
});
81+
82+
test('returns undefined when source is not plain object', () => {
83+
const result = getResponsePayloadBytes([1, 2, 3]);
84+
expect(result).toBe(undefined);
85+
});
7586
});
7687

7788
describe('handles content-length header', () => {

‎packages/kbn-legacy-logging/src/utils/get_payload_size.ts‎

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,13 @@
66
* Side Public License, v 1.
77
*/
88

9-
import type { ReadStream } from 'fs';
9+
import { isPlainObject } from 'lodash';
10+
import { ReadStream } from 'fs';
1011
import type { ResponseObject } from '@hapi/hapi';
1112

1213
const isBuffer = (obj: unknown): obj is Buffer => Buffer.isBuffer(obj);
13-
const isObject = (obj: unknown): obj is Record<string, unknown> =>
14-
typeof obj === 'object' && obj !== null;
1514
const isFsReadStream = (obj: unknown): obj is ReadStream =>
16-
typeof obj === 'object' && obj !== null && 'bytesRead' in obj;
15+
typeof obj === 'object' && obj !== null && 'bytesRead' in obj && obj instanceof ReadStream;
1716
const isString = (obj: unknown): obj is string => typeof obj === 'string';
1817

1918
/**
@@ -56,7 +55,7 @@ export function getResponsePayloadBytes(
5655
return Buffer.byteLength(payload);
5756
}
5857

59-
if (isObject(payload)) {
58+
if (isPlainObject(payload)) {
6059
return Buffer.byteLength(JSON.stringify(payload));
6160
}
6261

‎rfcs/images/api_doc_pick.png‎

80.6 KB
Loading

0 commit comments

Comments
 (0)