Add temporary lens-dashboard-app transform type to transformWorkpadIn

cqliu1 · cqliu1 · commit f82191f03e98 · 2026-03-10T13:11:18.000-07:00
diff --git a/x-pack/platform/plugins/private/canvas/server/embeddable/transform_workpad_in.test.ts b/x-pack/platform/plugins/private/canvas/server/embeddable/transform_workpad_in.test.ts
@@ -12,18 +12,48 @@ import { transformWorkpadIn } from './transform_workpad_in';
 import { embeddableService, logger } from '../kibana_services';
 import { getDecodedConfig, makeWorkpad } from './fixtures';
 
+const mockLensTransformIn = jest.fn((config: any) => {
+  const { savedObjectId, ...remainingConfig } = config;
+  return {
+    state: remainingConfig,
+    references: [
+      { id: savedObjectId, name: 'savedObjectRef', type: 'lens' },
+    ] as SavedObjectReference[],
+  };
+});
+
+const mockVisualizationTransformIn = jest.fn((config: any) => {
+  const { savedObjectId, ...remainingConfig } = config;
+  return {
+    state: remainingConfig,
+    references: [
+      { id: savedObjectId, name: 'savedObjectRef', type: 'visualization' },
+    ] as SavedObjectReference[],
+  };
+});
+
+const mockMapTransformIn = jest.fn((config: any) => {
+  const { savedObjectId, ...remainingConfig } = config;
+  return {
+    state: remainingConfig,
+    references: [
+      { id: savedObjectId, name: 'savedObjectRef', type: 'map' },
+    ] as SavedObjectReference[],
+  };
+});
 jest.mock('../kibana_services', () => ({
   embeddableService: {
-    getTransforms: jest.fn().mockReturnValue({
-      transformIn: jest.fn((config: any) => {
-        const { savedObjectId, ...remainingConfig } = config;
-        return {
-          state: { ...remainingConfig },
-          references: [
-            { id: savedObjectId, name: 'savedObjectRef', type: 'lens' },
-          ] as SavedObjectReference[],
-        };
-      }),
+    getTransforms: jest.fn((type: string) => {
+      switch (type) {
+        case 'lens-dashboard-app':
+          return { transformIn: mockLensTransformIn };
+        case 'visualization':
+          return { transformIn: mockVisualizationTransformIn };
+        case 'map':
+          return { transformIn: mockMapTransformIn };
+        default:
+          return;
+      }
     }),
   },
   logger: {
@@ -32,7 +62,7 @@ jest.mock('../kibana_services', () => ({
 }));
 
 describe('transformWorkpadIn', () => {
-  it('transforms embeddable config on the way in', () => {
+  it('transforms embeddable with lens config from stored state to REST API state', () => {
     const workpad = makeWorkpad(
       `embeddable type="lens" config="${encode({
         title: 'Test lens embeddable',
@@ -52,12 +82,67 @@ describe('transformWorkpadIn', () => {
       },
     ]);
 
-    expect(embeddableService?.getTransforms('lens')?.transformIn).toHaveBeenCalledWith({
+    expect(embeddableService?.getTransforms).toHaveBeenCalledWith('lens-dashboard-app');
+    expect(mockLensTransformIn).toHaveBeenCalledWith({
       savedObjectId: 'test-id',
       title: 'Test lens embeddable',
     });
   });
 
+  it('transforms embeddable with visualization config from stored state to REST API state', () => {
+    const workpad = makeWorkpad(
+      `embeddable type="visualization" config="${encode({
+        title: 'Test visualization embeddable',
+        savedObjectId: 'test-id',
+      })}"`
+    );
+
+    const { attributes, references } = transformWorkpadIn(workpad);
+    expect(getDecodedConfig(attributes)).toEqual({
+      title: 'Test visualization embeddable',
+    });
+    expect(references).toEqual([
+      {
+        id: 'test-id',
+        name: 'element-id:savedObjectRef',
+        type: 'visualization',
+      },
+    ]);
+
+    expect(embeddableService?.getTransforms).toHaveBeenCalledWith('visualization');
+    expect(mockVisualizationTransformIn).toHaveBeenCalledWith({
+      savedObjectId: 'test-id',
+      title: 'Test visualization embeddable',
+    });
+  });
+
+  it('transforms embeddable with map config from stored state to REST API state', () => {
+    const workpad = makeWorkpad(
+      `embeddable type="map" config="${encode({
+        title: 'Test map embeddable',
+        savedObjectId: 'test-id',
+      })}"`
+    );
+
+    const { attributes, references } = transformWorkpadIn(workpad);
+    expect(getDecodedConfig(attributes)).toEqual({
+      title: 'Test map embeddable',
+    });
+    expect(references).toEqual([
+      {
+        id: 'test-id',
+        name: 'element-id:savedObjectRef',
+        type: 'map',
+      },
+    ]);
+
+    expect(embeddableService?.getTransforms).toHaveBeenCalledWith('map');
+    expect(mockMapTransformIn).toHaveBeenCalledWith({
+      savedObjectId: 'test-id',
+      title: 'Test map embeddable',
+    });
+  });
+
   it('logs warnings when transformation fails and returns the original embeddable config and no references', () => {
     (embeddableService.getTransforms as jest.Mock).mockReturnValue({
       transformIn: jest.fn(() => {
diff --git a/x-pack/platform/plugins/private/canvas/server/embeddable/transform_workpad_in.ts b/x-pack/platform/plugins/private/canvas/server/embeddable/transform_workpad_in.ts
@@ -28,7 +28,11 @@ export const transformWorkpadIn = (
         if (fn.function === 'embeddable') {
           const embeddableConfig = decode(fn.arguments.config[0] as string);
           const embeddableType = fn.arguments.type[0] as string;
-          const transforms = embeddableService.getTransforms(embeddableType);
+          // Temporary escape hatch for lens as code
+          // TODO remove when lens as code transforms are ready for production
+          const transformType = embeddableType === 'lens' ? 'lens-dashboard-app' : embeddableType;
+          const transforms = embeddableService.getTransforms(transformType);
+
           try {
             if (transforms?.transformIn) {
               const { state, references: panelReferences = [] } =
