address feedback

alisonelizabeth · alisonelizabeth · commit ef25c2265b21 · 2020-04-14T12:28:01.000-04:00
diff --git a/x-pack/plugins/ingest_pipelines/public/application/components/pipeline_form/pipeline_form.tsx b/x-pack/plugins/ingest_pipelines/public/application/components/pipeline_form/pipeline_form.tsx
@@ -80,7 +80,12 @@ export const PipelineForm: React.FunctionComponent<Props> = ({
         </>
       ) : null}
 
-      <Form form={form} data-test-subj="pipelineForm">
+      <Form
+        form={form}
+        data-test-subj="pipelineForm"
+        isInvalid={form.isSubmitted && !form.isValid}
+        error={form.getErrors()}
+      >
         {/* Name field with optional version field */}
         <FormRow
           title={
@@ -267,7 +272,7 @@ export const PipelineForm: React.FunctionComponent<Props> = ({
                   iconType="check"
                   onClick={form.submit}
                   data-test-subj="submitButton"
-                  disabled={form.isValid === false}
+                  disabled={form.isSubmitted && form.isValid === false}
                   isLoading={isSaving}
                 >
                   {
diff --git a/x-pack/plugins/ingest_pipelines/public/application/components/pipeline_form/schema.tsx b/x-pack/plugins/ingest_pipelines/public/application/components/pipeline_form/schema.tsx
@@ -22,8 +22,8 @@ const { toInt } = fieldFormatters;
 const stringifyJson = (json: { [key: string]: unknown }): string =>
   Array.isArray(json) ? JSON.stringify(json, null, 2) : '[\n\n]';
 
-const parseJson = (jsonString: string) => {
-  let parsedJSON;
+const parseJson = (jsonString: string): object[] => {
+  let parsedJSON: any;
 
   try {
     parsedJSON = JSON.parse(jsonString);
diff --git a/x-pack/plugins/ingest_pipelines/public/application/sections/pipelines_list/empty_list.tsx b/x-pack/plugins/ingest_pipelines/public/application/sections/pipelines_list/empty_list.tsx
@@ -6,6 +6,7 @@
 import React, { FunctionComponent } from 'react';
 import { i18n } from '@kbn/i18n';
 import { EuiButton, EuiEmptyPrompt } from '@elastic/eui';
+import { BASE_PATH } from '../../../../common/constants';
 
 interface Props {
   onClick: () => void;
@@ -22,7 +23,7 @@ export const EmptyList: FunctionComponent<Props> = ({ onClick }) => (
       </h2>
     }
     actions={
-      <EuiButton onClick={onClick}>
+      <EuiButton href={`#${BASE_PATH}/create`}>
         {i18n.translate('xpack.ingestPipelines.list.table.emptyPrompt.createButtonLabel', {
           defaultMessage: 'Create pipeline',
         })}
diff --git a/x-pack/plugins/ingest_pipelines/public/application/sections/pipelines_list/main.tsx b/x-pack/plugins/ingest_pipelines/public/application/sections/pipelines_list/main.tsx
@@ -65,7 +65,7 @@ export const PipelinesList: React.FunctionComponent = () => {
       />
     );
   } else {
-    content = <EmptyList onClick={() => {}} />;
+    content = <EmptyList />;
   }
 
   return (
diff --git a/x-pack/plugins/ingest_pipelines/public/application/services/breadcrumbs.ts b/x-pack/plugins/ingest_pipelines/public/application/services/breadcrumbs.ts
@@ -9,31 +9,23 @@ import { ManagementAppMountParams } from '../../../../../../src/plugins/manageme
 
 type SetBreadcrumbs = ManagementAppMountParams['setBreadcrumbs'];
 
+const homeBreadcrumbText = i18n.translate('xpack.ingestPipelines.breadcrumb.pipelinesLabel', {
+  defaultMessage: 'Ingest Pipelines',
+});
+
 export class BreadcrumbService {
   private breadcrumbs: {
     [key: string]: Array<{
       text: string;
       href?: string;
     }>;
   } = {
-    home: [],
-  };
-  private setBreadcrumbsHandler?: SetBreadcrumbs;
-
-  public setup(setBreadcrumbsHandler: SetBreadcrumbs): void {
-    const homeBreadcrumbText = i18n.translate('xpack.ingestPipelines.breadcrumb.pipelinesLabel', {
-      defaultMessage: 'Ingest Pipelines',
-    });
-
-    this.setBreadcrumbsHandler = setBreadcrumbsHandler;
-
-    this.breadcrumbs.home = [
+    home: [
       {
         text: homeBreadcrumbText,
       },
-    ];
-
-    this.breadcrumbs.create = [
+    ],
+    create: [
       {
         text: homeBreadcrumbText,
         href: `#${BASE_PATH}`,
@@ -43,7 +35,13 @@ export class BreadcrumbService {
           defaultMessage: 'Create pipeline',
         }),
       },
-    ];
+    ],
+  };
+
+  private setBreadcrumbsHandler?: SetBreadcrumbs;
+
+  public setup(setBreadcrumbsHandler: SetBreadcrumbs): void {
+    this.setBreadcrumbsHandler = setBreadcrumbsHandler;
   }
 
   public setBreadcrumbs(type: 'create' | 'home'): void {

Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,7 @@ export const PipelinesList: React.FunctionComponent = () => {`
`65`	`65`	`/>`
`66`	`66`	`);`
`67`	`67`	`} else {`
`68`		`- content = <EmptyList onClick={() => {}} />;`
	`68`	`+ content = <EmptyList />;`
`69`	`69`	`}`
`70`	`70`
`71`	`71`	`return (`