code review

Liza K · Liza K · commit ecd5ccecee37 · 2020-09-23T22:21:28.000+03:00
diff --git a/src/plugins/data/public/search/errors/painless_error.tsx b/src/plugins/data/public/search/errors/painless_error.tsx
@@ -33,7 +33,7 @@ export class PainlessError extends KbnError {
 
     super(
       i18n.translate('data.painlessError.painlessScriptedFieldErrorMessage', {
-        defaultMessage: "Error with Painless scripted field '{script}'.",
+        defaultMessage: "Error executing Painless script: '{script}'.",
         values: { script: rootCause?.script },
       })
     );
diff --git a/src/plugins/data/public/search/search_interceptor.test.ts b/src/plugins/data/public/search/search_interceptor.test.ts
@@ -91,7 +91,7 @@ describe('SearchInterceptor', () => {
       }
     });
 
-    test('Search error should be throttled', async (done) => {
+    test('Search error should be debounced', async (done) => {
       const mockResponse: any = {
         result: 500,
         body: {
diff --git a/src/plugins/data/public/search/search_interceptor.ts b/src/plugins/data/public/search/search_interceptor.ts
@@ -17,7 +17,7 @@
  * under the License.
  */
 
-import { get, trimEnd, throttle } from 'lodash';
+import { get, trimEnd, debounce } from 'lodash';
 import { BehaviorSubject, throwError, timer, defer, from, Observable, NEVER } from 'rxjs';
 import { catchError, finalize } from 'rxjs/operators';
 import { CoreStart, CoreSetup, ToastsSetup } from 'kibana/public';
@@ -173,12 +173,16 @@ export class SearchInterceptor {
    * error notification per session.
    * @internal
    */
-  private showTimeoutError = throttle((e: SearchTimeoutError) => {
-    this.deps.toasts.addDanger({
-      title: 'Timed out',
-      text: toMountPoint(e.getErrorMessage(this.application)),
-    });
-  }, 30000);
+  private showTimeoutError = debounce(
+    (e: SearchTimeoutError) => {
+      this.deps.toasts.addDanger({
+        title: 'Timed out',
+        text: toMountPoint(e.getErrorMessage(this.application)),
+      });
+    },
+    30000,
+    { leading: true, trailing: false }
+  );
 
   /**
    * Searches using the given `search` method. Overrides the `AbortSignal` with one that will abort

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ describe('SearchInterceptor', () => {`
`91`	`91`	`}`
`92`	`92`	`});`
`93`	`93`
`94`		`- test('Search error should be throttled', async (done) => {`
	`94`	`+ test('Search error should be debounced', async (done) => {`
`95`	`95`	`const mockResponse: any = {`
`96`	`96`	`result: 500,`
`97`	`97`	`body: {`