add support for positive_score_impact field to rank_feature

alisonelizabeth · alisonelizabeth · commit eaffc6b12f84 · 2020-09-04T16:25:35.000-04:00
diff --git a/x-pack/plugins/index_management/public/application/components/mappings_editor/components/document_fields/fields/field_types/index.ts b/x-pack/plugins/index_management/public/application/components/mappings_editor/components/document_fields/fields/field_types/index.ts
@@ -28,6 +28,7 @@ import { ObjectType } from './object_type';
 import { OtherType } from './other_type';
 import { NestedType } from './nested_type';
 import { JoinType } from './join_type';
+import { RankFeatureType } from './rank_feature_type';
 
 const typeToParametersFormMap: { [key in DataType]?: ComponentType<any> } = {
   alias: AliasType,
@@ -52,6 +53,7 @@ const typeToParametersFormMap: { [key in DataType]?: ComponentType<any> } = {
   other: OtherType,
   nested: NestedType,
   join: JoinType,
+  rank_feature: RankFeatureType,
 };
 
 export const getParametersFormForType = (
diff --git a/x-pack/plugins/index_management/public/application/components/mappings_editor/components/document_fields/fields/field_types/rank_feature_type.tsx b/x-pack/plugins/index_management/public/application/components/mappings_editor/components/document_fields/fields/field_types/rank_feature_type.tsx
@@ -0,0 +1,32 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License;
+ * you may not use this file except in compliance with the Elastic License.
+ */
+import React from 'react';
+import { i18n } from '@kbn/i18n';
+
+import { BasicParametersSection, EditFieldFormRow } from '../edit_field';
+
+export const RankFeatureType = () => {
+  return (
+    <BasicParametersSection>
+      <EditFieldFormRow
+        title={i18n.translate(
+          'xpack.idxMgmt.mappingsEditor.rankFeature.positiveScoreImpactFieldTitle',
+          {
+            defaultMessage: 'Positive score impact',
+          }
+        )}
+        description={i18n.translate(
+          'xpack.idxMgmt.mappingsEditor.rankFeature.positiveScoreImpactFieldDescription',
+          {
+            defaultMessage:
+              'Rank features that correlate negatively with the score should disable this field.',
+          }
+        )}
+        formFieldPath="positive_score_impact"
+      />
+    </BasicParametersSection>
+  );
+};
diff --git a/x-pack/plugins/index_management/public/application/components/mappings_editor/constants/parameters_definition.tsx b/x-pack/plugins/index_management/public/application/components/mappings_editor/constants/parameters_definition.tsx
@@ -692,6 +692,12 @@ export const PARAMETERS_DEFINITION: { [key in ParameterName]: ParameterDefinitio
     },
     schema: t.boolean,
   },
+  positive_score_impact: {
+    fieldConfig: {
+      defaultValue: true,
+    },
+    schema: t.boolean,
+  },
   preserve_separators: {
     fieldConfig: {
       defaultValue: true,
diff --git a/x-pack/plugins/index_management/public/application/components/mappings_editor/types/document_fields.ts b/x-pack/plugins/index_management/public/application/components/mappings_editor/types/document_fields.ts
@@ -124,6 +124,7 @@ export type ParameterName =
   | 'eager_global_ordinals_join'
   | 'index_prefixes'
   | 'index_phrases'
+  | 'positive_score_impact'
   | 'norms'
   | 'norms_keyword'
   | 'term_vector'
