Skip to content

Commit eaecad4

Browse files
martiansnoopepixa
authored andcommitted
Fix typos in style guide
Fixes #6289
1 parent 3f67d1f commit eaecad4

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

STYLEGUIDE.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -586,7 +586,7 @@ Use slashes for both single line and multi line comments. Try to write
586586
comments that explain higher level mechanisms or clarify difficult
587587
segments of your code. **Don't use comments to restate trivial things**.
588588

589-
***Exception:*** Comment blocks describing a function and it's arguments (docblock) should start with `/**`, contain a single `*` at the begining of each line, and end with `*/`.
589+
***Exception:*** Comment blocks describing a function and its arguments (docblock) should start with `/**`, contain a single `*` at the beginning of each line, and end with `*/`.
590590

591591
*Right:*
592592

@@ -656,7 +656,7 @@ function ClassName() {
656656
var ClassName = function () {};
657657
```
658658

659-
### Inhertiance should be done with a utility
659+
### Inheritance should be done with a utility
660660

661661
While you can do it with pure JS, a utility will remove a lot of boilerplate, and be more readable and functional.
662662

@@ -685,7 +685,7 @@ Square.prototype = Object.create(Shape);
685685

686686
### Keep Constructors Small
687687

688-
It is often the case that there are properties that can't be defined on the prototype, or work that needs to be done to completely create an object (like call it's Super class). This is all that should be done within constructors.
688+
It is often the case that there are properties that can't be defined on the prototype, or work that needs to be done to completely create an object (like call its Super class). This is all that should be done within constructors.
689689

690690
Try to follow the [Write small functions](#write-small-functions) rule here too.
691691

@@ -775,7 +775,7 @@ Several already exist, and can be found in `src/kibana/utils/_mixins.js`
775775

776776
## Filenames
777777

778-
All filenames should use `snake_case` and *can* start with an underscore if the module is not intended to be used outside of it's containing module.
778+
All filenames should use `snake_case` and *can* start with an underscore if the module is not intended to be used outside of its containing module.
779779

780780
*Right:*
781781
- `src/kibana/index_patterns/index_pattern.js`
@@ -856,7 +856,7 @@ app.service('CustomService', function(Promise, otherDeps) {
856856

857857
### Routes
858858

859-
Angular routes are defined using a custom require modules named `routes` that remove much of the required boilerplate.
859+
Angular routes are defined using a custom require module named `routes` that remove much of the required boilerplate.
860860

861861
```js
862862
require('ui/routes')
@@ -869,7 +869,7 @@ require('ui/routes')
869869

870870
## Multiple attribute values
871871

872-
When a node has multiple attributes that would cause it to exceed the line character limit, each attribute including the first should be on its own line with a single indent. Also, when a node that is styled in this way has child nodes, there should be a blank line between the openening parent tag and the first child tag.
872+
When a node has multiple attributes that would cause it to exceed the line character limit, each attribute including the first should be on its own line with a single indent. Also, when a node that is styled in this way has child nodes, there should be a blank line between the opening parent tag and the first child tag.
873873

874874
```
875875
<ul

0 commit comments

Comments
 (0)