Skip to content

Commit e8f2f7e

Browse files
dej611mbondyra
andcommitted
[Lens] Fix Workspace hidden when using Safari (#92616)
Co-authored-by: Marta Bondyra <marta.bondyra@elastic.co>
1 parent a44d5a6 commit e8f2f7e

4 files changed

Lines changed: 8 additions & 18 deletions

File tree

x-pack/plugins/lens/public/drag_drop/__snapshots__/drag_drop.test.tsx.snap

Lines changed: 5 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/plugins/lens/public/drag_drop/drag_drop.scss

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -81,13 +81,6 @@
8181
}
8282
}
8383

84-
.lnsDragDrop__container {
85-
position: relative;
86-
overflow: visible !important; // sass-lint:disable-line no-important
87-
width: 100%;
88-
height: 100%;
89-
}
90-
9184
.lnsDragDrop__reorderableDrop {
9285
position: absolute;
9386
width: 100%;

x-pack/plugins/lens/public/drag_drop/drag_drop.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -456,7 +456,7 @@ const DropInner = memo(function DropInner(props: DropInnerProps) {
456456
isActiveDropTarget && dropType !== 'reorder' && dragging?.ghost ? dragging.ghost : undefined;
457457

458458
return (
459-
<div className="lnsDragDrop__container">
459+
<>
460460
{React.cloneElement(children, {
461461
'data-test-subj': dataTestSubj || 'lnsDragDrop',
462462
className: classNames(children.props.className, classes, className),
@@ -471,7 +471,7 @@ const DropInner = memo(function DropInner(props: DropInnerProps) {
471471
style: ghost.style,
472472
})
473473
: null}
474-
</div>
474+
</>
475475
);
476476
});
477477

x-pack/plugins/lens/public/editor_frame_service/editor_frame/workspace_panel/workspace_panel_wrapper.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
min-height: $euiSizeXXL * 10;
1212
overflow: visible;
1313
border: none;
14+
height: 100%;
1415

1516
.lnsWorkspacePanelWrapper__pageContentBody {
1617
@include euiScrollBar;

0 commit comments

Comments
 (0)