[Security Solution] styling for notes' panel (#74274)

angorayc · angorayc · commit e553f4da126b · 2020-08-04T21:20:57.000+01:00
* styling for notes' pannel

* styling

* remove additional const

* styling
diff --git a/x-pack/plugins/security_solution/public/timelines/components/notes/index.tsx b/x-pack/plugins/security_solution/public/timelines/components/notes/index.tsx
@@ -9,7 +9,6 @@ import {
   EuiInMemoryTableProps,
   EuiModalBody,
   EuiModalHeader,
-  EuiPanel,
   EuiSpacer,
 } from '@elastic/eui';
 import React, { useState } from 'react';
@@ -20,7 +19,6 @@ import { Note } from '../../../common/lib/note';
 import { AddNote } from './add_note';
 import { columns } from './columns';
 import { AssociateNote, GetNewNoteId, NotesCount, search, UpdateNote } from './helpers';
-import { NOTES_PANEL_WIDTH, NOTES_PANEL_HEIGHT } from '../timeline/properties/notes_size';
 import { TimelineStatusLiteral, TimelineStatus } from '../../../../common/types/timeline';
 
 interface Props {
@@ -32,23 +30,12 @@ interface Props {
   updateNote: UpdateNote;
 }
 
-const NotesPanel = styled(EuiPanel)`
-  height: ${NOTES_PANEL_HEIGHT}px;
-  width: ${NOTES_PANEL_WIDTH}px;
-
-  & thead {
-    display: none;
-  }
-`;
-
-NotesPanel.displayName = 'NotesPanel';
-
 const InMemoryTable: typeof EuiInMemoryTable & { displayName: string } = styled(
   EuiInMemoryTable as React.ComponentType<EuiInMemoryTableProps<Note>>
 )`
-  overflow-x: hidden;
-  overflow-y: auto;
-  height: 220px;
+  & thead {
+    display: none;
+  }
 ` as any; // eslint-disable-line @typescript-eslint/no-explicit-any
 
 InMemoryTable.displayName = 'InMemoryTable';
@@ -60,7 +47,7 @@ export const Notes = React.memo<Props>(
     const isImmutable = status === TimelineStatus.immutable;
 
     return (
-      <NotesPanel>
+      <>
         <EuiModalHeader>
           <NotesCount noteIds={noteIds} />
         </EuiModalHeader>
@@ -84,7 +71,7 @@ export const Notes = React.memo<Props>(
             sorting={true}
           />
         </EuiModalBody>
-      </NotesPanel>
+      </>
     );
   }
 );
diff --git a/x-pack/plugins/security_solution/public/timelines/components/timeline/properties/notes_size.ts b/x-pack/plugins/security_solution/public/timelines/components/timeline/properties/notes_size.ts
@@ -5,4 +5,3 @@
  */
 
 export const NOTES_PANEL_WIDTH = 1024;
-export const NOTES_PANEL_HEIGHT = 750;

Original file line number	Diff line number	Diff line change
`@@ -5,4 +5,3 @@`
`5`	`5`	`*/`
`6`	`6`
`7`	`7`	`export const NOTES_PANEL_WIDTH = 1024;`
`8`		`-export const NOTES_PANEL_HEIGHT = 750;`