Remove hook cleanup now that elastic/eui#5068 is merged

cee-chen · cee-chen · commit e40ebfa92946 · 2021-08-25T08:58:54.000-07:00
diff --git a/x-pack/plugins/lens/public/datatable_visualization/components/cell_value.tsx b/x-pack/plugins/lens/public/datatable_visualization/components/cell_value.tsx
@@ -53,18 +53,6 @@ export const createGridCell = (
           }
         }
       }
-      // make sure to clean it up when something change
-      // this avoids cell's styling to stick forever
-      return () => {
-        if (minMaxByColumnId?.[originalId]) {
-          setCellProps({
-            style: {
-              backgroundColor: undefined,
-              color: undefined,
-            },
-          });
-        }
-      };
     }, [rowValue, columnId, setCellProps, colorMode, palette, minMaxByColumnId, getColorForValue]);
 
     return (

Original file line number	Diff line number	Diff line change
`@@ -53,18 +53,6 @@ export const createGridCell = (`
`53`	`53`	`}`
`54`	`54`	`}`
`55`	`55`	`}`
`56`		`- // make sure to clean it up when something change`
`57`		`- // this avoids cell's styling to stick forever`
`58`		`- return () => {`
`59`		`- if (minMaxByColumnId?.[originalId]) {`
`60`		`- setCellProps({`
`61`		`- style: {`
`62`		`- backgroundColor: undefined,`
`63`		`- color: undefined,`
`64`		`- },`
`65`		`- });`
`66`		`- }`
`67`		`- };`
`68`	`56`	`}, [rowValue, columnId, setCellProps, colorMode, palette, minMaxByColumnId, getColorForValue]);`
`69`	`57`
`70`	`58`	`return (`