moved save policy function into edit policy section

jloleysens · jloleysens · commit e27161b22d15 · 2020-11-06T09:38:39.000+01:00
diff --git a/x-pack/plugins/index_lifecycle_management/public/application/lib/policies.ts b/x-pack/plugins/index_lifecycle_management/public/application/lib/policies.ts
@@ -3,16 +3,8 @@
  * or more contributor license agreements. Licensed under the Elastic License;
  * you may not use this file except in compliance with the Elastic License.
  */
-import { i18n } from '@kbn/i18n';
-import { METRIC_TYPE } from '@kbn/analytics';
 
-import { PolicyFromES, SerializedPolicy } from '../../../common/types';
-
-import { toasts } from '../services/notification';
-import { savePolicy as savePolicyApi } from '../services/api';
-import { getUiMetricsForPhases, trackUiMetric } from '../services/ui_metric';
-import { showApiError } from '../services/api_errors';
-import { UIM_POLICY_CREATE, UIM_POLICY_UPDATE } from '../constants';
+import { PolicyFromES } from '../../../common/types';
 
 export const splitSizeAndUnits = (field: string): { size: string; units: string } => {
   let size = '';
@@ -38,39 +30,3 @@ export const getPolicyByName = (
     return policies.find((policy: PolicyFromES) => policy.name === policyName);
   }
 };
-
-export const savePolicy = async (
-  serializedPolicy: SerializedPolicy,
-  isNew: boolean
-): Promise<boolean> => {
-  try {
-    await savePolicyApi(serializedPolicy);
-  } catch (err) {
-    const title = i18n.translate('xpack.indexLifecycleMgmt.editPolicy.saveErrorMessage', {
-      defaultMessage: 'Error saving lifecycle policy {lifecycleName}',
-      values: { lifecycleName: serializedPolicy.name },
-    });
-    showApiError(err, title);
-    return false;
-  }
-
-  const uiMetrics = getUiMetricsForPhases(serializedPolicy.phases);
-  uiMetrics.push(isNew ? UIM_POLICY_CREATE : UIM_POLICY_UPDATE);
-  trackUiMetric(METRIC_TYPE.COUNT, uiMetrics);
-
-  const message = i18n.translate('xpack.indexLifecycleMgmt.editPolicy.successfulSaveMessage', {
-    defaultMessage: '{verb} lifecycle policy "{lifecycleName}"',
-    values: {
-      verb: isNew
-        ? i18n.translate('xpack.indexLifecycleMgmt.editPolicy.createdMessage', {
-            defaultMessage: 'Created',
-          })
-        : i18n.translate('xpack.indexLifecycleMgmt.editPolicy.updatedMessage', {
-            defaultMessage: 'Updated',
-          }),
-      lifecycleName: serializedPolicy.name,
-    },
-  });
-  toasts.addSuccess(message);
-  return true;
-};
diff --git a/x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/edit_policy.tsx b/x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/edit_policy.tsx
@@ -34,7 +34,7 @@ import { useForm, Form, UseField, TextField, useFormData } from '../../../shared
 
 import { toasts } from '../../services/notification';
 
-import { savePolicy } from '../../lib/policies';
+import { savePolicy } from './save_policy';
 
 import {
   LearnMoreLink,
diff --git a/x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/save_policy.ts b/x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/save_policy.ts
@@ -0,0 +1,52 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License;
+ * you may not use this file except in compliance with the Elastic License.
+ */
+import { i18n } from '@kbn/i18n';
+import { METRIC_TYPE } from '@kbn/analytics';
+
+import { SerializedPolicy } from '../../../../common/types';
+
+import { UIM_POLICY_CREATE, UIM_POLICY_UPDATE } from '../../constants';
+
+import { toasts } from '../../services/notification';
+import { savePolicy as savePolicyApi } from '../../services/api';
+import { getUiMetricsForPhases, trackUiMetric } from '../../services/ui_metric';
+import { showApiError } from '../../services/api_errors';
+
+export const savePolicy = async (
+  serializedPolicy: SerializedPolicy,
+  isNew: boolean
+): Promise<boolean> => {
+  try {
+    await savePolicyApi(serializedPolicy);
+  } catch (err) {
+    const title = i18n.translate('xpack.indexLifecycleMgmt.editPolicy.saveErrorMessage', {
+      defaultMessage: 'Error saving lifecycle policy {lifecycleName}',
+      values: { lifecycleName: serializedPolicy.name },
+    });
+    showApiError(err, title);
+    return false;
+  }
+
+  const uiMetrics = getUiMetricsForPhases(serializedPolicy.phases);
+  uiMetrics.push(isNew ? UIM_POLICY_CREATE : UIM_POLICY_UPDATE);
+  trackUiMetric(METRIC_TYPE.COUNT, uiMetrics);
+
+  const message = i18n.translate('xpack.indexLifecycleMgmt.editPolicy.successfulSaveMessage', {
+    defaultMessage: '{verb} lifecycle policy "{lifecycleName}"',
+    values: {
+      verb: isNew
+        ? i18n.translate('xpack.indexLifecycleMgmt.editPolicy.createdMessage', {
+            defaultMessage: 'Created',
+          })
+        : i18n.translate('xpack.indexLifecycleMgmt.editPolicy.updatedMessage', {
+            defaultMessage: 'Updated',
+          }),
+      lifecycleName: serializedPolicy.name,
+    },
+  });
+  toasts.addSuccess(message);
+  return true;
+};
