do not refetch license if signature header absents from a response (#79645)

mshustov · kibanamachine · mshustov · commit e03b789c0ac2 · 2020-10-12T20:13:54.000+03:00
Co-authored-by: Kibana Machine &lt;42973632+kibanamachine@users.noreply.github.com&gt;
diff --git a/x-pack/plugins/licensing/public/plugin.test.ts b/x-pack/plugins/licensing/public/plugin.test.ts
@@ -240,6 +240,46 @@ describe('licensing plugin', () => {
       expect(coreSetup.http.get).toHaveBeenCalledTimes(1);
     });
 
+    it('http interceptor does not trigger re-fetch if signature header is not present', async () => {
+      const sessionStorage = coreMock.createStorage();
+      plugin = new LicensingPlugin(coreMock.createPluginInitializerContext(), sessionStorage);
+
+      const coreSetup = coreMock.createSetup();
+
+      coreSetup.http.get.mockResolvedValue(licenseMock.createLicense({ signature: 'signature-1' }));
+
+      let registeredInterceptor: HttpInterceptor;
+      coreSetup.http.intercept.mockImplementation((interceptor: HttpInterceptor) => {
+        registeredInterceptor = interceptor;
+        return () => undefined;
+      });
+
+      await plugin.setup(coreSetup);
+      await plugin.start(coreStart);
+      expect(registeredInterceptor!.response).toBeDefined();
+
+      const httpResponse = {
+        response: {
+          headers: {
+            get(name: string) {
+              if (name === 'kbn-license-sig') {
+                return undefined;
+              }
+              throw new Error('unexpected header');
+            },
+          },
+        },
+        request: {
+          url: 'http://10.10.10.10:5601/api/hello',
+        },
+      };
+      expect(coreSetup.http.get).toHaveBeenCalledTimes(0);
+
+      await registeredInterceptor!.response!(httpResponse as any, null as any);
+
+      expect(coreSetup.http.get).toHaveBeenCalledTimes(0);
+    });
+
     it('http interceptor does not trigger license re-fetch for anonymous pages', async () => {
       const sessionStorage = coreMock.createStorage();
       plugin = new LicensingPlugin(coreMock.createPluginInitializerContext(), sessionStorage);
diff --git a/x-pack/plugins/licensing/public/plugin.ts b/x-pack/plugins/licensing/public/plugin.ts
@@ -101,7 +101,7 @@ export class LicensingPlugin implements Plugin<LicensingPluginSetup, LicensingPl
         if (core.http.anonymousPaths.isAnonymous(window.location.pathname)) return httpResponse;
         if (httpResponse.response) {
           const signatureHeader = httpResponse.response.headers.get('kbn-license-sig');
-          if (this.prevSignature !== signatureHeader) {
+          if (typeof signatureHeader === 'string' && this.prevSignature !== signatureHeader) {
             if (!httpResponse.request!.url.includes(this.infoEndpoint)) {
               signatureUpdated$.next();
             }

Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@ export class LicensingPlugin implements Plugin<LicensingPluginSetup, LicensingPl`
`101`	`101`	`if (core.http.anonymousPaths.isAnonymous(window.location.pathname)) return httpResponse;`
`102`	`102`	`if (httpResponse.response) {`
`103`	`103`	`const signatureHeader = httpResponse.response.headers.get('kbn-license-sig');`
`104`		`- if (this.prevSignature !== signatureHeader) {`
	`104`	`+ if (typeof signatureHeader === 'string' && this.prevSignature !== signatureHeader) {`
`105`	`105`	`if (!httpResponse.request!.url.includes(this.infoEndpoint)) {`
`106`	`106`	`signatureUpdated$.next();`
`107`	`107`	`}`