Move setClient call from plugin.start to plugin.setup

John Schulz · John Schulz · commit dcab4fa96bfe · 2019-11-08T15:01:54.000-05:00
diff --git a/x-pack/legacy/plugins/integrations_manager/public/plugin.tsx b/x-pack/legacy/plugins/integrations_manager/public/plugin.tsx
@@ -36,10 +36,11 @@ export interface PluginCore {
 export class Plugin {
   constructor(initializerContext: PluginInitializerContext) {}
   // called when plugin is setting up during Kibana's startup sequence
-  public setup(core: CoreSetup) {}
+  public setup(core: CoreSetup) {
+    setClient(core.http.fetch);
+  }
   // called after all plugins are set up
   public start(core: PluginCore) {
-    setClient(core.http.fetch);
     ReactDOM.render(<App core={core} />, core.renderTo);
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -36,10 +36,11 @@ export interface PluginCore {`
`36`	`36`	`export class Plugin {`
`37`	`37`	`constructor(initializerContext: PluginInitializerContext) {}`
`38`	`38`	`// called when plugin is setting up during Kibana's startup sequence`
`39`		`- public setup(core: CoreSetup) {}`
	`39`	`+ public setup(core: CoreSetup) {`
	`40`	`+ setClient(core.http.fetch);`
	`41`	`+ }`
`40`	`42`	`// called after all plugins are set up`
`41`	`43`	`public start(core: PluginCore) {`
`42`		`- setClient(core.http.fetch);`
`43`	`44`	`ReactDOM.render(<App core={core} />, core.renderTo);`
`44`	`45`	`}`
`45`	`46`	`}`