refactor actionItem to be coming from hook

tomsonpl · tomsonpl · commit db57ba43e79b · 2022-05-19T11:38:43.000+02:00
diff --git a/x-pack/plugins/security_solution/public/detections/components/alerts_table/timeline_actions/alert_context_menu.tsx b/x-pack/plugins/security_solution/public/detections/components/alerts_table/timeline_actions/alert_context_menu.tsx
@@ -13,7 +13,7 @@ import { connect, ConnectedProps } from 'react-redux';
 import { ExceptionListType } from '@kbn/securitysolution-io-ts-list-types';
 import { get } from 'lodash/fp';
 import { DEFAULT_ACTION_BUTTON_WIDTH } from '@kbn/timelines-plugin/public';
-import { OsqueryActionItem } from '../../osquery/osquery_action_item';
+import { useOsqueryContextActionItem } from '../../osquery/use_osquery_context_action_item';
 import { OsqueryFlyout } from '../../osquery/osquery_flyout';
 import { useRouteSpy } from '../../../../common/utils/route/use_route_spy';
 import { buildGetAlertByIdQuery } from '../../../../common/components/exceptions/helpers';
@@ -196,13 +196,7 @@ const AlertContextMenuComponent: React.FC<AlertContextMenuProps & PropsFromRedux
     setPopover(false);
   }, []);
 
-  const osqueryActionItem = useMemo(
-    () =>
-      OsqueryActionItem({
-        handleClick: handleOnOsqueryClick,
-      }),
-    [handleOnOsqueryClick]
-  );
+  const { osqueryActionItems } = useOsqueryContextActionItem({ handleClick: handleOnOsqueryClick });
 
   const items: React.ReactElement[] = useMemo(
     () =>
@@ -211,12 +205,12 @@ const AlertContextMenuComponent: React.FC<AlertContextMenuProps & PropsFromRedux
             ...addToCaseActionItems,
             ...statusActionItems,
             ...exceptionActionItems,
-            ...(agentId ? [osqueryActionItem] : []),
+            ...(agentId ? osqueryActionItems : []),
           ]
         : [
             ...addToCaseActionItems,
             ...eventFilterActionItems,
-            ...(agentId ? [osqueryActionItem] : []),
+            ...(agentId ? osqueryActionItems : []),
           ],
     [
       isEvent,
@@ -225,7 +219,7 @@ const AlertContextMenuComponent: React.FC<AlertContextMenuProps & PropsFromRedux
       statusActionItems,
       exceptionActionItems,
       agentId,
-      osqueryActionItem,
+      osqueryActionItems,
       eventFilterActionItems,
     ]
   );
diff --git a/x-pack/plugins/security_solution/public/detections/components/osquery/osquery_action_item.tsx b/x-pack/plugins/security_solution/public/detections/components/osquery/osquery_action_item.tsx
@@ -13,14 +13,12 @@ interface IProps {
   handleClick: () => void;
 }
 
-export const OsqueryActionItem = ({ handleClick }: IProps) => {
-  return (
-    <EuiContextMenuItem
-      key="osquery-action-item"
-      data-test-subj="osquery-action-item"
-      onClick={handleClick}
-    >
-      {ACTION_OSQUERY}
-    </EuiContextMenuItem>
-  );
-};
+export const OsqueryActionItem = ({ handleClick }: IProps) => (
+  <EuiContextMenuItem
+    key="osquery-action-item"
+    data-test-subj="osquery-action-item"
+    onClick={handleClick}
+  >
+    {ACTION_OSQUERY}
+  </EuiContextMenuItem>
+);
diff --git a/x-pack/plugins/security_solution/public/detections/components/osquery/use_osquery_context_action_item.tsx b/x-pack/plugins/security_solution/public/detections/components/osquery/use_osquery_context_action_item.tsx
@@ -0,0 +1,27 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0; you may not use this file except in compliance with the Elastic License
+ * 2.0.
+ */
+
+import React, { useMemo } from 'react';
+import { OsqueryActionItem } from './osquery_action_item';
+import { useKibana } from '../../../common/lib/kibana';
+
+interface IProps {
+  handleClick: () => void;
+}
+
+export const useOsqueryContextActionItem = ({ handleClick }: IProps): any => {
+  const osqueryActionItem = useMemo(
+    () => <OsqueryActionItem handleClick={handleClick} />,
+    [handleClick]
+  );
+  const permissions = useKibana().services.application.capabilities.osquery;
+
+  return {
+    osqueryActionItems:
+      permissions.writeLiveQueries || permissions.runSavedQueries ? [osqueryActionItem] : [],
+  };
+};
