Skip to content

Commit d9e333d

Browse files
chrisbmarchrisbmar
committed
remove ab enabled from sample data action buttons
1 parent eb23f35 commit d9e333d

3 files changed

Lines changed: 28 additions & 53 deletions

File tree

‎x-pack/solutions/search/plugins/search_homepage/public/components/sample_data_action_button.test.tsx‎

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ import React from 'react';
1010
import { __IntlProvider as IntlProvider } from '@kbn/i18n-react';
1111
import { SampleDataActionButton } from './sample_data_action_button';
1212
import { useKibana } from '../hooks/use_kibana';
13-
import { AGENT_BUILDER_ENABLED_SETTING_ID } from '@kbn/management-settings-ids';
1413
import { useSampleDataStatus } from '../hooks/use_sample_data_status';
1514

1615
jest.mock('../hooks/use_kibana');
@@ -22,8 +21,6 @@ jest.mock('../hooks/use_ingest_data', () => ({
2221
})),
2322
}));
2423

25-
const mockUiSettingsGet = jest.fn();
26-
2724
const renderWithWrapper = () => {
2825
render(
2926
<IntlProvider locale="en">
@@ -37,10 +34,9 @@ describe('Sample data action button', () => {
3734
jest.clearAllMocks();
3835
});
3936

40-
it('renders elements when agentBuilder is enabled', async () => {
37+
it('renders agent builder menu item', async () => {
4138
(useKibana as jest.Mock).mockReturnValue({
4239
services: {
43-
uiSettings: { get: mockUiSettingsGet },
4440
share: {
4541
url: {
4642
locators: {
@@ -59,11 +55,6 @@ describe('Sample data action button', () => {
5955
dashboardId: 'dashboardId',
6056
isLoading: false,
6157
});
62-
mockUiSettingsGet.mockImplementation((key: string) => {
63-
if (key === AGENT_BUILDER_ENABLED_SETTING_ID) {
64-
return true;
65-
}
66-
});
6758

6859
renderWithWrapper();
6960

‎x-pack/solutions/search/plugins/search_homepage/public/components/sample_data_action_button.tsx‎

Lines changed: 14 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ import {
1616
} from '@elastic/eui';
1717
import { FormattedMessage } from '@kbn/i18n-react';
1818
import { i18n } from '@kbn/i18n';
19-
import { AGENT_BUILDER_ENABLED_SETTING_ID } from '@kbn/management-settings-ids';
2019
import { useIngestSampleData } from '../hooks/use_ingest_data';
2120
import { useSampleDataStatus } from '../hooks/use_sample_data_status';
2221
import { useKibana } from '../hooks/use_kibana';
@@ -45,7 +44,6 @@ export const SampleDataActionButton = ({
4544
isInstalling,
4645
} = useSampleDataStatus();
4746
const [isShowViewDataOptions, setShowViewDataOptions] = useState(false);
48-
const isAgentBuilderAvailable = uiSettings.get<boolean>(AGENT_BUILDER_ENABLED_SETTING_ID, false);
4947

5048
const onInstallButtonClick = useCallback(() => {
5149
usageTracker.click(clickEvent);
@@ -82,11 +80,9 @@ export const SampleDataActionButton = ({
8280
}, [share, indexName]);
8381

8482
const navigateToAgentBuilder = useCallback(async () => {
85-
if (isAgentBuilderAvailable) {
86-
const agentBuilderLocator = share.url.locators.get('AGENT_BUILDER_LOCATOR_ID');
87-
await agentBuilderLocator?.navigate({});
88-
}
89-
}, [share, isAgentBuilderAvailable]);
83+
const agentBuilderLocator = share.url.locators.get('AGENT_BUILDER_LOCATOR_ID');
84+
await agentBuilderLocator?.navigate({});
85+
}, [share]);
9086

9187
if (isStatusLoading) {
9288
return null;
@@ -118,21 +114,17 @@ export const SampleDataActionButton = ({
118114
<EuiContextMenuPanel
119115
css={{ minWidth: 250 }}
120116
items={[
121-
...(isAgentBuilderAvailable
122-
? [
123-
<EuiContextMenuItem
124-
key="agentBuilder"
125-
onClick={navigateToAgentBuilder}
126-
icon="comment"
127-
data-test-subj="agentBuilderMenuItem"
128-
>
129-
<FormattedMessage
130-
id="xpack.searchHomepage.shared.createIndex.ingestSampleData.linkToAgentBuilder"
131-
defaultMessage="Agents"
132-
/>
133-
</EuiContextMenuItem>,
134-
]
135-
: []),
117+
<EuiContextMenuItem
118+
key="agentBuilder"
119+
onClick={navigateToAgentBuilder}
120+
icon="comment"
121+
data-test-subj="agentBuilderMenuItem"
122+
>
123+
<FormattedMessage
124+
id="xpack.searchHomepage.shared.createIndex.ingestSampleData.linkToAgentBuilder"
125+
defaultMessage="Agents"
126+
/>
127+
</EuiContextMenuItem>,
136128
<EuiContextMenuItem key="discover" onClick={navigateToDiscover} icon="discoverApp">
137129
<FormattedMessage
138130
id="xpack.searchHomepage.sampleData.linkToDiscover"

‎x-pack/solutions/search/plugins/search_indices/public/components/shared/sample_data_action_button.tsx‎

Lines changed: 13 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ import {
1616
} from '@elastic/eui';
1717
import { FormattedMessage } from '@kbn/i18n-react';
1818
import { i18n } from '@kbn/i18n';
19-
import { AGENT_BUILDER_ENABLED_SETTING_ID } from '@kbn/management-settings-ids';
2019
import { useSampleDataStatus } from '../../hooks/use_sample_data_status';
2120
import { useKibana } from '../../hooks/use_kibana';
2221
import { navigateToIndexDetails } from '../utils';
@@ -42,7 +41,6 @@ export const SampleDataActionButton: React.FC<SampleDataActionButtonProps> = ({
4241
isInstalling,
4342
} = useSampleDataStatus();
4443
const [isShowViewDataOptions, setShowViewDataOptions] = useState(false);
45-
const isAgentBuilderAvailable = uiSettings.get<boolean>(AGENT_BUILDER_ENABLED_SETTING_ID, false);
4644

4745
const onViewButtonClick = useCallback(() => {
4846
setShowViewDataOptions(true);
@@ -68,11 +66,9 @@ export const SampleDataActionButton: React.FC<SampleDataActionButtonProps> = ({
6866
const navigateToDashboard = useNavigateToDashboard(dashboardId);
6967

7068
const navigateToAgentBuilder = useCallback(async () => {
71-
if (isAgentBuilderAvailable) {
72-
const agentBuilderLocator = share.url.locators.get('AGENT_BUILDER_LOCATOR_ID');
73-
await agentBuilderLocator?.navigate({});
74-
}
75-
}, [share, isAgentBuilderAvailable]);
69+
const agentBuilderLocator = share.url.locators.get('AGENT_BUILDER_LOCATOR_ID');
70+
await agentBuilderLocator?.navigate({});
71+
}, [share]);
7672

7773
if (isStatusLoading) {
7874
return null;
@@ -106,20 +102,16 @@ export const SampleDataActionButton: React.FC<SampleDataActionButtonProps> = ({
106102
<EuiContextMenuPanel
107103
css={{ minWidth: 250 }}
108104
items={[
109-
...(isAgentBuilderAvailable
110-
? [
111-
<EuiContextMenuItem
112-
key="agentBuilder"
113-
onClick={navigateToAgentBuilder}
114-
icon="comment"
115-
>
116-
<FormattedMessage
117-
id="xpack.searchIndices.shared.createIndex.ingestSampleData.linkToAgentBuilder"
118-
defaultMessage="Agents"
119-
/>
120-
</EuiContextMenuItem>,
121-
]
122-
: []),
105+
<EuiContextMenuItem
106+
key="agentBuilder"
107+
onClick={navigateToAgentBuilder}
108+
icon="comment"
109+
>
110+
<FormattedMessage
111+
id="xpack.searchIndices.shared.createIndex.ingestSampleData.linkToAgentBuilder"
112+
defaultMessage="Agents"
113+
/>
114+
</EuiContextMenuItem>,
123115
<EuiContextMenuItem key="discover" onClick={navigateToDiscover} icon="discoverApp">
124116
<FormattedMessage
125117
id="xpack.searchIndices.shared.createIndex.ingestSampleData.linkToDiscover"

0 commit comments

Comments
 (0)