Clean up top nav bar code

Heenawter · Heenawter · commit d6cb83aac078 · 2023-03-02T10:06:21.000-07:00
diff --git a/src/plugins/dashboard/public/dashboard_app/top_nav/dashboard_top_nav.tsx b/src/plugins/dashboard/public/dashboard_app/top_nav/dashboard_top_nav.tsx
@@ -123,6 +123,19 @@ export function DashboardTopNav({
     if (!embedSettings) setChromeVisibility(viewMode !== ViewMode.PRINT);
   }, [embedSettings, setChromeVisibility, viewMode]);
 
+  /**
+   * Keep track of the height of the top nav bar as it changes so that the padding at the top of the
+   * dashboard viewport can be adjusted dynamically as it changes
+   */
+  const resizeRef = useRef<HTMLDivElement>(null);
+  const dimensions = useResizeObserver(resizeRef.current);
+  useEffect(() => {
+    if (dimensions.height !== currentHeight) {
+      onHeightChange(dimensions.height);
+      setCurrentHeight(dimensions.height);
+    }
+  }, [dimensions, currentHeight, onHeightChange]);
+
   /**
    * populate recently accessed, and set is chrome visible.
    */
@@ -220,16 +233,6 @@ export function DashboardTopNav({
     dashboardContainer.clearOverlays();
   });
 
-  const resizeRef = useRef<HTMLDivElement>(null);
-  const dimensions = useResizeObserver(resizeRef.current);
-
-  useEffect(() => {
-    if (dimensions.height !== currentHeight) {
-      onHeightChange(dimensions.height);
-      setCurrentHeight(dimensions.height);
-    }
-  }, [dimensions, currentHeight, onHeightChange]);
-
   return (
     <div ref={resizeRef} className={'dashboardTopNav'}>
       <h1
