Skip to content

Commit d649f0d

Browse files
committed
Fix integration tests
1 parent 13b1f0d commit d649f0d

6 files changed

Lines changed: 57 additions & 38 deletions

File tree

x-pack/test/alerting_api_integration/security_and_spaces/group2/tests/actions/bulk_enqueue.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ export default function ({ getService }: FtrProviderContext) {
100100
const startDate = new Date().toISOString();
101101

102102
const connectorId = 'system-connector-test.system-action-kibana-privileges';
103-
const name = 'System action: test.system-action-kibana-privileges';
103+
const name = 'Test system action with kibana privileges';
104104
const reference = `actions-enqueue-${scenario.id}:${space.id}:${connectorId}`;
105105

106106
const response = await supertestWithoutAuth

x-pack/test/alerting_api_integration/security_and_spaces/group2/tests/actions/execute.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -508,7 +508,7 @@ export default function ({ getService }: FtrProviderContext) {
508508
it('should authorize system actions correctly', async () => {
509509
const startDate = new Date().toISOString();
510510
const connectorId = 'system-connector-test.system-action-kibana-privileges';
511-
const name = 'System action: test.system-action-kibana-privileges';
511+
const name = 'Test system action with kibana privileges';
512512
const reference = `actions-enqueue-${scenario.id}:${space.id}:${connectorId}`;
513513

514514
/**

x-pack/test/alerting_api_integration/security_and_spaces/group2/tests/actions/get_all_system.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ export default function getAllActionTests({ getService }: FtrProviderContext) {
132132
is_deprecated: false,
133133
is_preconfigured: false,
134134
is_system_action: true,
135-
name: 'System action: test.system-action',
135+
name: 'Test system action',
136136
referenced_by_count: 0,
137137
},
138138
{
@@ -141,7 +141,7 @@ export default function getAllActionTests({ getService }: FtrProviderContext) {
141141
is_deprecated: false,
142142
is_preconfigured: false,
143143
is_system_action: true,
144-
name: 'System action: test.system-action-connector-adapter',
144+
name: 'Test system action with a connector adapter set',
145145
referenced_by_count: 0,
146146
},
147147
{
@@ -150,7 +150,7 @@ export default function getAllActionTests({ getService }: FtrProviderContext) {
150150
is_deprecated: false,
151151
is_preconfigured: false,
152152
is_system_action: true,
153-
name: 'System action: test.system-action-kibana-privileges',
153+
name: 'Test system action with kibana privileges',
154154
referenced_by_count: 0,
155155
},
156156
{
@@ -319,7 +319,7 @@ export default function getAllActionTests({ getService }: FtrProviderContext) {
319319
is_deprecated: false,
320320
is_preconfigured: false,
321321
is_system_action: true,
322-
name: 'System action: test.system-action',
322+
name: 'Test system action',
323323
referenced_by_count: 0,
324324
},
325325
{
@@ -328,7 +328,7 @@ export default function getAllActionTests({ getService }: FtrProviderContext) {
328328
is_deprecated: false,
329329
is_preconfigured: false,
330330
is_system_action: true,
331-
name: 'System action: test.system-action-connector-adapter',
331+
name: 'Test system action with a connector adapter set',
332332
referenced_by_count: 0,
333333
},
334334
{
@@ -337,7 +337,7 @@ export default function getAllActionTests({ getService }: FtrProviderContext) {
337337
is_deprecated: false,
338338
is_preconfigured: false,
339339
is_system_action: true,
340-
name: 'System action: test.system-action-kibana-privileges',
340+
name: 'Test system action with kibana privileges',
341341
referenced_by_count: 0,
342342
},
343343
{
@@ -469,7 +469,7 @@ export default function getAllActionTests({ getService }: FtrProviderContext) {
469469
is_deprecated: false,
470470
is_preconfigured: false,
471471
is_system_action: true,
472-
name: 'System action: test.system-action',
472+
name: 'Test system action',
473473
referenced_by_count: 0,
474474
},
475475
{
@@ -478,7 +478,7 @@ export default function getAllActionTests({ getService }: FtrProviderContext) {
478478
is_deprecated: false,
479479
is_preconfigured: false,
480480
is_system_action: true,
481-
name: 'System action: test.system-action-connector-adapter',
481+
name: 'Test system action with a connector adapter set',
482482
referenced_by_count: 0,
483483
},
484484
{
@@ -487,7 +487,7 @@ export default function getAllActionTests({ getService }: FtrProviderContext) {
487487
is_deprecated: false,
488488
is_preconfigured: false,
489489
is_system_action: true,
490-
name: 'System action: test.system-action-kibana-privileges',
490+
name: 'Test system action with kibana privileges',
491491
referenced_by_count: 0,
492492
},
493493
{

x-pack/test/alerting_api_integration/security_and_spaces/group4/tests/alerting/alerts.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1880,7 +1880,7 @@ instanceStateValue: true
18801880
const space = SuperuserAtSpace1.space;
18811881

18821882
const connectorId = 'system-connector-test.system-action-connector-adapter';
1883-
const name = 'System action: test.system-action-connector-adapter';
1883+
const name = 'Test system action with a connector adapter set';
18841884

18851885
it('should use connector adapters correctly on system actions', async () => {
18861886
const alertUtils = new AlertUtils({

x-pack/test/alerting_api_integration/spaces_only/tests/actions/execute.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -342,7 +342,7 @@ export default function ({ getService }: FtrProviderContext) {
342342
*/
343343
it('should execute system actions correctly', async () => {
344344
const connectorId = 'system-connector-test.system-action';
345-
const name = 'System action: test.system-action';
345+
const name = 'Test system action';
346346

347347
const response = await supertest
348348
.post(
@@ -375,7 +375,7 @@ export default function ({ getService }: FtrProviderContext) {
375375
*/
376376
it('should execute system actions with kibana privileges correctly', async () => {
377377
const connectorId = 'system-connector-test.system-action-kibana-privileges';
378-
const name = 'System action: test.system-action-kibana-privileges';
378+
const name = 'Test system action with kibana privileges';
379379

380380
const response = await supertest
381381
.post(

x-pack/test/alerting_api_integration/spaces_only/tests/actions/get_all_system.ts

Lines changed: 43 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,15 @@ export default function getAllActionTests({ getService }: FtrProviderContext) {
5656
is_system_action: false,
5757
referenced_by_count: 0,
5858
},
59+
{
60+
connector_type_id: '.cases',
61+
id: 'system-connector-.cases',
62+
is_deprecated: false,
63+
is_preconfigured: false,
64+
is_system_action: true,
65+
name: 'Cases',
66+
referenced_by_count: 0,
67+
},
5968
{
6069
id: createdAction.id,
6170
is_preconfigured: false,
@@ -114,13 +123,22 @@ export default function getAllActionTests({ getService }: FtrProviderContext) {
114123
name: 'Slack#xyz',
115124
referenced_by_count: 0,
116125
},
126+
{
127+
id: 'custom-system-abc-connector',
128+
is_preconfigured: true,
129+
is_deprecated: false,
130+
connector_type_id: 'system-abc-action-type',
131+
is_system_action: false,
132+
name: 'SystemABC',
133+
referenced_by_count: 0,
134+
},
117135
{
118136
connector_type_id: 'test.system-action',
119137
id: 'system-connector-test.system-action',
120138
is_deprecated: false,
121139
is_preconfigured: false,
122140
is_system_action: true,
123-
name: 'System action: test.system-action',
141+
name: 'Test system action',
124142
referenced_by_count: 0,
125143
},
126144
{
@@ -129,7 +147,7 @@ export default function getAllActionTests({ getService }: FtrProviderContext) {
129147
is_deprecated: false,
130148
is_preconfigured: false,
131149
is_system_action: true,
132-
name: 'System action: test.system-action-connector-adapter',
150+
name: 'Test system action with a connector adapter set',
133151
referenced_by_count: 0,
134152
},
135153
{
@@ -138,18 +156,10 @@ export default function getAllActionTests({ getService }: FtrProviderContext) {
138156
is_deprecated: false,
139157
is_preconfigured: false,
140158
is_system_action: true,
141-
name: 'System action: test.system-action-kibana-privileges',
142-
referenced_by_count: 0,
143-
},
144-
{
145-
id: 'custom-system-abc-connector',
146-
is_preconfigured: true,
147-
is_deprecated: false,
148-
connector_type_id: 'system-abc-action-type',
149-
is_system_action: false,
150-
name: 'SystemABC',
159+
name: 'Test system action with kibana privileges',
151160
referenced_by_count: 0,
152161
},
162+
153163
{
154164
id: 'preconfigured.test.index-record',
155165
is_preconfigured: true,
@@ -208,6 +218,15 @@ export default function getAllActionTests({ getService }: FtrProviderContext) {
208218
is_system_action: false,
209219
referenced_by_count: 0,
210220
},
221+
{
222+
connector_type_id: '.cases',
223+
id: 'system-connector-.cases',
224+
is_deprecated: false,
225+
is_preconfigured: false,
226+
is_system_action: true,
227+
name: 'Cases',
228+
referenced_by_count: 0,
229+
},
211230
{
212231
connector_type_id: '.email',
213232
id: 'notification-email',
@@ -253,13 +272,22 @@ export default function getAllActionTests({ getService }: FtrProviderContext) {
253272
name: 'Slack#xyz',
254273
referenced_by_count: 0,
255274
},
275+
{
276+
id: 'custom-system-abc-connector',
277+
is_preconfigured: true,
278+
is_deprecated: false,
279+
is_system_action: false,
280+
connector_type_id: 'system-abc-action-type',
281+
name: 'SystemABC',
282+
referenced_by_count: 0,
283+
},
256284
{
257285
connector_type_id: 'test.system-action',
258286
id: 'system-connector-test.system-action',
259287
is_deprecated: false,
260288
is_preconfigured: false,
261289
is_system_action: true,
262-
name: 'System action: test.system-action',
290+
name: 'Test system action',
263291
referenced_by_count: 0,
264292
},
265293
{
@@ -268,7 +296,7 @@ export default function getAllActionTests({ getService }: FtrProviderContext) {
268296
is_deprecated: false,
269297
is_preconfigured: false,
270298
is_system_action: true,
271-
name: 'System action: test.system-action-connector-adapter',
299+
name: 'Test system action with a connector adapter set',
272300
referenced_by_count: 0,
273301
},
274302
{
@@ -277,16 +305,7 @@ export default function getAllActionTests({ getService }: FtrProviderContext) {
277305
is_deprecated: false,
278306
is_preconfigured: false,
279307
is_system_action: true,
280-
name: 'System action: test.system-action-kibana-privileges',
281-
referenced_by_count: 0,
282-
},
283-
{
284-
id: 'custom-system-abc-connector',
285-
is_preconfigured: true,
286-
is_deprecated: false,
287-
is_system_action: false,
288-
connector_type_id: 'system-abc-action-type',
289-
name: 'SystemABC',
308+
name: 'Test system action with kibana privileges',
290309
referenced_by_count: 0,
291310
},
292311
{

0 commit comments

Comments
 (0)