use real reference in dataset and assert against it.

pgayvallet · pgayvallet · commit d45327270ebe · 2020-05-15T17:49:01.000+02:00
diff --git a/test/functional/apps/saved_objects_management/edit_saved_object.ts b/test/functional/apps/saved_objects_management/edit_saved_object.ts
@@ -125,6 +125,13 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
     it('preserves the object references when saving', async () => {
       const testVisualizationUrl =
         '/management/kibana/objects/savedVisualizations/75c3e060-1e7c-11e9-8488-65449e65d0ed';
+      const visualizationRefs = [
+        {
+          name: 'kibanaSavedObjectMeta.searchSourceJSON.index',
+          type: 'index-pattern',
+          id: 'logstash-*',
+        },
+      ];
 
       await PageObjects.settings.navigateTo();
       await PageObjects.settings.clickKibanaSavedObjects();
@@ -136,7 +143,9 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
 
       await testSubjects.existOrFail('savedObjectEditSave');
 
-      let referencesValue = await getAceEditorFieldValue('references');
+      let displayedReferencesValue = await getAceEditorFieldValue('references');
+
+      expect(JSON.parse(displayedReferencesValue)).to.eql(visualizationRefs);
 
       await focusAndClickButton('savedObjectEditSave');
 
@@ -145,9 +154,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
       await PageObjects.common.navigateToActualUrl('kibana', testVisualizationUrl);
 
       // Parsing to avoid random keys ordering issues in raw string comparison
-      expect(JSON.parse(await getAceEditorFieldValue('references'))).to.eql(
-        JSON.parse(referencesValue)
-      );
+      expect(JSON.parse(await getAceEditorFieldValue('references'))).to.eql(visualizationRefs);
 
       await setAceEditorFieldValue('references', JSON.stringify([], undefined, 2));
 
@@ -157,9 +164,9 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
 
       await PageObjects.common.navigateToActualUrl('kibana', testVisualizationUrl);
 
-      referencesValue = await getAceEditorFieldValue('references');
+      displayedReferencesValue = await getAceEditorFieldValue('references');
 
-      expect(JSON.parse(referencesValue)).to.eql([]);
+      expect(JSON.parse(displayedReferencesValue)).to.eql([]);
     });
   });
 }
diff --git a/test/functional/fixtures/es_archiver/saved_objects_management/edit_saved_object/data.json b/test/functional/fixtures/es_archiver/saved_objects_management/edit_saved_object/data.json
@@ -41,7 +41,7 @@
     },
     "references" : [
       {
-        "name" : "control_0_index_pattern",
+        "name" : "kibanaSavedObjectMeta.searchSourceJSON.index",
         "type" : "index-pattern",
         "id" : "logstash-*"
       }

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@`
`41`	`41`	`},`
`42`	`42`	`"references" : [`
`43`	`43`	`{`
`44`		`- "name" : "control_0_index_pattern",`
	`44`	`+ "name" : "kibanaSavedObjectMeta.searchSourceJSON.index",`
`45`	`45`	`"type" : "index-pattern",`
`46`	`46`	`"id" : "logstash-*"`
`47`	`47`	`}`