Skip to content

Commit cfeb658

Browse files
parkiinoparkiino
committed
fix small comments
1 parent 570834f commit cfeb658

4 files changed

Lines changed: 20 additions & 21 deletions

File tree

‎x-pack/plugins/security_solution/public/app/home/home_navigations.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ export const navTabs: SiemNavTab = {
2727
},
2828
[SecurityPageName.alerts]: {
2929
id: SecurityPageName.alerts,
30-
name: i18n.Alerts,
30+
name: i18n.ALERTS,
3131
href: APP_ALERTS_PATH,
3232
disabled: false,
3333
urlKey: 'alerts',

‎x-pack/plugins/security_solution/public/app/home/translations.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ export const DETECTION_ENGINE = i18n.translate(
2525
}
2626
);
2727

28-
export const Alerts = i18n.translate('xpack.securitySolution.navigation.alerts', {
28+
export const ALERTS = i18n.translate('xpack.securitySolution.navigation.alerts', {
2929
defaultMessage: 'Alerts',
3030
});
3131

‎x-pack/plugins/security_solution/public/management/components/management_empty_state.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ const HostsEmptyState = React.memo<{
183183
headerComponent={
184184
<FormattedMessage
185185
id="xpack.securitySolution.endpoint.hostList.noHostsPrompt"
186-
defaultMessage="You have a policy, but no Hosts are deployed!"
186+
defaultMessage="You have a policy, but no hosts are deployed!"
187187
/>
188188
}
189189
bodyComponent={

‎x-pack/plugins/security_solution/public/plugin.tsx‎

Lines changed: 17 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,15 @@ import { ConfigureEndpointPackageConfig } from './management/pages/policy/view/i
4848
import { State, createStore, createInitialState } from './common/store';
4949
import { SecurityPageName } from './app/types';
5050
import { manageOldSiemRoutes } from './helpers';
51+
import {
52+
OVERVIEW,
53+
HOSTS,
54+
NETWORK,
55+
TIMELINES,
56+
ALERTS,
57+
CASE,
58+
ADMINISTRATION,
59+
} from './app/home/translations';
5160

5261
export class Plugin implements IPlugin<PluginSetup, PluginStart, SetupPlugins, StartPlugins> {
5362
private kibanaVersion: string;
@@ -100,7 +109,7 @@ export class Plugin implements IPlugin<PluginSetup, PluginStart, SetupPlugins, S
100109
}),
101110
appRoute: APP_PATH,
102111
navLinkStatus: AppNavLinkStatus.hidden,
103-
mount: async (params: AppMountParameters) => {
112+
mount: async () => {
104113
const [{ application }] = await core.getStartServices();
105114
application.navigateToApp(`${APP_ID}:${SecurityPageName.overview}`, { replace: true });
106115
return () => true;
@@ -109,9 +118,7 @@ export class Plugin implements IPlugin<PluginSetup, PluginStart, SetupPlugins, S
109118

110119
core.application.register({
111120
id: `${APP_ID}:${SecurityPageName.overview}`,
112-
title: i18n.translate('xpack.securitySolution.overviewPage.title', {
113-
defaultMessage: 'Overview',
114-
}),
121+
title: OVERVIEW,
115122
order: 9000,
116123
euiIconType: APP_ICON,
117124
category: DEFAULT_APP_CATEGORIES.security,
@@ -139,9 +146,7 @@ export class Plugin implements IPlugin<PluginSetup, PluginStart, SetupPlugins, S
139146

140147
core.application.register({
141148
id: `${APP_ID}:${SecurityPageName.alerts}`,
142-
title: i18n.translate('xpack.securitySolution.alertsPage.title', {
143-
defaultMessage: 'Alerts',
144-
}),
149+
title: ALERTS,
145150
order: 9001,
146151
euiIconType: APP_ICON,
147152
category: DEFAULT_APP_CATEGORIES.security,
@@ -168,7 +173,7 @@ export class Plugin implements IPlugin<PluginSetup, PluginStart, SetupPlugins, S
168173

169174
core.application.register({
170175
id: `${APP_ID}:${SecurityPageName.hosts}`,
171-
title: i18n.translate('xpack.securitySolution.hostsPage.title', { defaultMessage: 'Hosts' }),
176+
title: HOSTS,
172177
order: 9002,
173178
euiIconType: APP_ICON,
174179
category: DEFAULT_APP_CATEGORIES.security,
@@ -195,9 +200,7 @@ export class Plugin implements IPlugin<PluginSetup, PluginStart, SetupPlugins, S
195200

196201
core.application.register({
197202
id: `${APP_ID}:${SecurityPageName.network}`,
198-
title: i18n.translate('xpack.securitySolution.networkPage.title', {
199-
defaultMessage: 'Network',
200-
}),
203+
title: NETWORK,
201204
order: 9002,
202205
euiIconType: APP_ICON,
203206
category: DEFAULT_APP_CATEGORIES.security,
@@ -224,9 +227,7 @@ export class Plugin implements IPlugin<PluginSetup, PluginStart, SetupPlugins, S
224227

225228
core.application.register({
226229
id: `${APP_ID}:${SecurityPageName.timelines}`,
227-
title: i18n.translate('xpack.securitySolution.timelinesPage.title', {
228-
defaultMessage: 'Timelines',
229-
}),
230+
title: TIMELINES,
230231
order: 9002,
231232
euiIconType: APP_ICON,
232233
category: DEFAULT_APP_CATEGORIES.security,
@@ -253,7 +254,7 @@ export class Plugin implements IPlugin<PluginSetup, PluginStart, SetupPlugins, S
253254

254255
core.application.register({
255256
id: `${APP_ID}:${SecurityPageName.case}`,
256-
title: 'Cases',
257+
title: CASE,
257258
order: 9002,
258259
euiIconType: APP_ICON,
259260
category: DEFAULT_APP_CATEGORIES.security,
@@ -280,9 +281,7 @@ export class Plugin implements IPlugin<PluginSetup, PluginStart, SetupPlugins, S
280281

281282
core.application.register({
282283
id: `${APP_ID}:${SecurityPageName.management}`,
283-
title: i18n.translate('xpack.securitySolution.administrationPage.title', {
284-
defaultMessage: 'Administration',
285-
}),
284+
title: ADMINISTRATION,
286285
order: 9002,
287286
euiIconType: APP_ICON,
288287
category: DEFAULT_APP_CATEGORIES.security,

0 commit comments

Comments
 (0)