Fixed duplication of create new modal (#86489) (#86535)

ThomThomson · web-flow · commit cf9dbf0003ca · 2020-12-19T14:42:30.000-05:00
diff --git a/src/plugins/dashboard/public/application/top_nav/dashboard_top_nav.tsx b/src/plugins/dashboard/public/application/top_nav/dashboard_top_nav.tsx
@@ -27,6 +27,7 @@ import { useKibana } from '../../services/kibana_react';
 import { IndexPattern, SavedQuery, TimefilterContract } from '../../services/data';
 import {
   EmbeddableFactoryNotFoundError,
+  EmbeddableInput,
   isErrorEmbeddable,
   openAddPanelFlyout,
   ViewMode,
@@ -135,10 +136,7 @@ export function DashboardTopNav({
     if (!factory) {
       throw new EmbeddableFactoryNotFoundError(type);
     }
-    const explicitInput = await factory.getExplicitInput();
-    if (dashboardContainer) {
-      await dashboardContainer.addNewEmbeddable(type, explicitInput);
-    }
+    await factory.create({} as EmbeddableInput, dashboardContainer);
   }, [dashboardContainer, embeddable]);
 
   const onChangeViewMode = useCallback(
