Skip to content

Commit cddb241

Browse files
nickofthymembondyra
andcommitted
[Lens] Fix Firefox inline editor scroll (#228625)
## Summary Fixes an issues in Firefox where the Lens flyout configuration was not scrollable. https://github.com/user-attachments/assets/e8e57fc6-b2c8-4354-be17-d41cb42317df Fixes #227939 ### Checklist - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. Co-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com>
1 parent 5d7a3a2 commit cddb241

2 files changed

Lines changed: 3 additions & 6 deletions

File tree

x-pack/platform/plugins/shared/lens/public/app_plugin/shared/edit_on_the_fly/get_edit_lens_configuration.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ const MaybeWrapper = ({
114114
size="s"
115115
hideCloseButton
116116
css={css`
117-
clip-path: polygon(-100% 0, 100% 0, 100% 100%, -100% 100%);
117+
clip-path: none; // needed to override the eui-flyout clip-path for dnd outside of the flyout
118118
`}
119119
>
120120
{children}

x-pack/platform/plugins/shared/lens/public/trigger_actions/open_lens_config/helpers.scss

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,9 @@
1-
// styles needed to display extra drop targets that are outside of the config panel main area while also allowing to scroll vertically
21
.lnsConfigPanel__overlay {
3-
clip-path: polygon(-100% 0, 100% 0, 100% 100%, -100% 100%);
2+
clip-path: none; // needed to override the eui-flyout clip-path for dnd outside of the flyout
43
max-inline-size: $euiSizeXXL * 20;
54
min-inline-size: $euiSizeXXL * 8;
65
background: $euiColorBackgroundBaseSubdued;
7-
@include euiBreakpoint('xs', 's', 'm') {
8-
clip-path: none;
9-
}
6+
107
.kbnOverlayMountWrapper {
118
padding-left: $euiFormMaxWidth;
129
margin-left: -$euiFormMaxWidth;

0 commit comments

Comments
 (0)