Skip to content

Commit cc382a5

Browse files
committed
chore: 🤖 remove url generators
1 parent 185e169 commit cc382a5

3 files changed

Lines changed: 1 addition & 129 deletions

File tree

‎x-pack/plugins/maps/public/plugin.ts‎

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,7 @@ import type {
3636
} from '../../../../src/plugins/visualizations/public';
3737
import { APP_ICON_SOLUTION, APP_ID, MAP_SAVED_OBJECT_TYPE } from '../common/constants';
3838
import { VISUALIZE_GEO_FIELD_TRIGGER } from '../../../../src/plugins/ui_actions/public';
39-
import {
40-
createMapsUrlGenerator,
41-
createRegionMapUrlGenerator,
42-
createTileMapUrlGenerator,
43-
} from './url_generator';
39+
import { createRegionMapUrlGenerator, createTileMapUrlGenerator } from './url_generator';
4440
import { visualizeGeoFieldAction } from './trigger_actions/visualize_geo_field_action';
4541
import { filterByMapExtentAction } from './trigger_actions/filter_by_map_extent_action';
4642
import { MapEmbeddableFactory } from './embeddable/map_embeddable_factory';
@@ -146,7 +142,6 @@ export class MapsPlugin
146142
useHashedUrl: coreStart.uiSettings.get('state:storeInSessionStorage'),
147143
};
148144
};
149-
plugins.share.urlGenerators.registerUrlGenerator(createMapsUrlGenerator(getStartServices));
150145
plugins.share.urlGenerators.registerUrlGenerator(createTileMapUrlGenerator(getStartServices));
151146
plugins.share.urlGenerators.registerUrlGenerator(createRegionMapUrlGenerator(getStartServices));
152147

‎x-pack/plugins/maps/public/url_generator.test.ts‎

Lines changed: 0 additions & 113 deletions
This file was deleted.

‎x-pack/plugins/maps/public/url_generator.ts‎

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ import { lazyLoadMapModules } from './lazy_load_bundle';
2323
const STATE_STORAGE_KEY = '_a';
2424
const GLOBAL_STATE_STORAGE_KEY = '_g';
2525

26-
export const MAPS_APP_URL_GENERATOR = 'MAPS_APP_URL_GENERATOR';
2726
export const MAPS_APP_TILE_MAP_URL_GENERATOR = 'MAPS_APP_TILE_MAP_URL_GENERATOR';
2827
export const MAPS_APP_REGION_MAP_URL_GENERATOR = 'MAPS_APP_REGION_MAP_URL_GENERATOR';
2928

@@ -112,15 +111,6 @@ async function createMapUrl({
112111
return url;
113112
}
114113

115-
export const createMapsUrlGenerator = (
116-
getStartServices: GetStartServices
117-
): UrlGeneratorsDefinition<typeof MAPS_APP_URL_GENERATOR> => ({
118-
id: MAPS_APP_URL_GENERATOR,
119-
createUrl: async (mapsUrlGeneratorState: MapsUrlGeneratorState): Promise<string> => {
120-
return createMapUrl({ ...mapsUrlGeneratorState, getStartServices });
121-
},
122-
});
123-
124114
export const createTileMapUrlGenerator = (
125115
getStartServices: GetStartServices
126116
): UrlGeneratorsDefinition<typeof MAPS_APP_TILE_MAP_URL_GENERATOR> => ({

0 commit comments

Comments
 (0)