PR comments, fix quick check failures

animehart · animehart · commit cc06d2793947 · 2024-09-13T18:19:47.000-07:00
diff --git a/x-pack/plugins/security_solution/public/cloud_security_posture/components/misconfiguration/misconfiguration_preview.tsx b/x-pack/plugins/security_solution/public/cloud_security_posture/components/misconfiguration/misconfiguration_preview.tsx
@@ -132,7 +132,7 @@ export const MisconfigurationsPreview = ({ hostName }: { hostName: string }) =>
   const failedFindings = data?.count.failed || 0;
 
   const { euiTheme } = useEuiTheme();
-  const hasMisconfigurationFindingsForThisQuery = passedFindings > 0 || failedFindings > 0;
+  const hasMisconfigurationFindings = passedFindings > 0 || failedFindings > 0;
   const hostNameFilterQuery = useMemo(
     () => (hostName ? buildHostNamesFilter([hostName]) : undefined),
     [hostName]
@@ -155,11 +155,11 @@ export const MisconfigurationsPreview = ({ hostName }: { hostName: string }) =>
       params: {
         name: hostName,
         isRiskScoreExist,
-        hasMisconfigurationFindingsForThisQuery,
+        hasMisconfigurationFindings,
         path: { tab: 'csp_insights' },
       },
     });
-  }, [hasMisconfigurationFindingsForThisQuery, hostName, isRiskScoreExist, openLeftPanel]);
+  }, [hasMisconfigurationFindings, hostName, isRiskScoreExist, openLeftPanel]);
   const link = useMemo(
     () =>
       !isPreviewMode
@@ -178,7 +178,7 @@ export const MisconfigurationsPreview = ({ hostName }: { hostName: string }) =>
   return (
     <ExpandablePanel
       header={{
-        iconType: hasMisconfigurationFindingsForThisQuery ? 'arrowStart' : '',
+        iconType: hasMisconfigurationFindings ? 'arrowStart' : '',
         title: (
           <EuiText
             size="xs"
@@ -192,12 +192,12 @@ export const MisconfigurationsPreview = ({ hostName }: { hostName: string }) =>
             />
           </EuiText>
         ),
-        link: hasMisconfigurationFindingsForThisQuery ? link : undefined,
+        link: hasMisconfigurationFindings ? link : undefined,
       }}
       data-test-subj={'securitySolutionFlyoutInsightsMisconfigurations'}
     >
       <EuiFlexGroup gutterSize="none">
-        {hasMisconfigurationFindingsForThisQuery ? (
+        {hasMisconfigurationFindings ? (
           <MisconfigurationPreviewScore
             passedFindings={passedFindings}
             failedFindings={failedFindings}
diff --git a/x-pack/plugins/security_solution/public/flyout/entity_details/host_details_left/index.test.tsx b/x-pack/plugins/security_solution/public/flyout/entity_details/host_details_left/index.test.tsx
@@ -69,7 +69,7 @@ describe('HostDetailsPanel', () => {
         name="elastic"
         isRiskScoreExist={false}
         scopeId={'scopeId'}
-        hasMisconfigurationFindingsForThisQuery={false}
+        hasMisconfigurationFindings={false}
       />,
       {
         wrapper: TestProviders,
@@ -84,7 +84,7 @@ describe('HostDetailsPanel', () => {
         name="elastic"
         isRiskScoreExist={false}
         scopeId={'scopeId'}
-        hasMisconfigurationFindingsForThisQuery={true}
+        hasMisconfigurationFindings={true}
       />,
       {
         wrapper: TestProviders,
diff --git a/x-pack/plugins/security_solution/public/flyout/entity_details/host_details_left/index.tsx b/x-pack/plugins/security_solution/public/flyout/entity_details/host_details_left/index.tsx
@@ -22,7 +22,7 @@ export interface HostDetailsPanelProps extends Record<string, unknown> {
   isRiskScoreExist: boolean;
   name: string;
   scopeId: string;
-  hasMisconfigurationFindingsForThisQuery?: boolean;
+  hasMisconfigurationFindings?: boolean;
   path?: {
     tab?: EntityDetailsLeftPanelTab;
   };
@@ -38,7 +38,7 @@ export const HostDetailsPanel = ({
   isRiskScoreExist,
   scopeId,
   path,
-  hasMisconfigurationFindingsForThisQuery,
+  hasMisconfigurationFindings,
 }: HostDetailsPanelProps) => {
   const [selectedTabId, setSelectedTabId] = useState(
     path?.tab === EntityDetailsLeftPanelTab.CSP_INSIGHTS
@@ -53,17 +53,11 @@ export const HostDetailsPanel = ({
       : [];
 
     // Determine if the Insights tab should be included
-    const insightsTab =
-      hasMisconfigurationFindingsForThisQuery
-        ? [getInsightsInputTab({ name, fieldName: 'host.name' })]
-        : [];
+    const insightsTab = hasMisconfigurationFindings
+      ? [getInsightsInputTab({ name, fieldName: 'host.name' })]
+      : [];
     return [[...riskScoreTab, ...insightsTab], EntityDetailsLeftPanelTab.RISK_INPUTS, () => {}];
-  }, [
-    isRiskScoreExist,
-    name,
-    scopeId,
-    hasMisconfigurationFindingsForThisQuery,
-  ]);
+  }, [isRiskScoreExist, name, scopeId, hasMisconfigurationFindings]);
 
   return (
     <>
diff --git a/x-pack/plugins/security_solution/public/flyout/entity_details/host_right/index.tsx b/x-pack/plugins/security_solution/public/flyout/entity_details/host_right/index.tsx
@@ -105,7 +105,7 @@ export const HostPanel = ({
   const passedFindings = data?.count.passed || 0;
   const failedFindings = data?.count.failed || 0;
 
-  const hasMisconfigurationFindingsForThisQuery = passedFindings > 0 || failedFindings > 0;
+  const hasMisconfigurationFindings = passedFindings > 0 || failedFindings > 0;
 
   useQueryInspector({
     deleteQuery,
@@ -129,18 +129,11 @@ export const HostPanel = ({
           scopeId,
           isRiskScoreExist,
           path: tab ? { tab } : undefined,
-          hasMisconfigurationFindingsForThisQuery,
+          hasMisconfigurationFindings,
         },
       });
     },
-    [
-      telemetry,
-      openLeftPanel,
-      hostName,
-      scopeId,
-      isRiskScoreExist,
-      hasMisconfigurationFindingsForThisQuery,
-    ]
+    [telemetry, openLeftPanel, hostName, scopeId, isRiskScoreExist, hasMisconfigurationFindings]
   );
 
   const openDefaultPanel = useCallback(
@@ -180,7 +173,7 @@ export const HostPanel = ({
           <>
             <FlyoutNavigation
               flyoutIsExpandable={
-                !isPreviewMode && (isRiskScoreExist || hasMisconfigurationFindingsForThisQuery)
+                !isPreviewMode && (isRiskScoreExist || hasMisconfigurationFindings)
               }
               expandDetails={openDefaultPanel}
             />
