[APM] Make error.exception.stacktrace.line optional

dgieselaar · dgieselaar · commit ca19ae18829d · 2020-01-23T18:20:47.000+01:00
diff --git a/x-pack/legacy/plugins/apm/public/components/shared/Stacktrace/FrameHeading.tsx b/x-pack/legacy/plugins/apm/public/components/shared/Stacktrace/FrameHeading.tsx
@@ -34,7 +34,7 @@ const FrameHeading: React.FC<Props> = ({ stackframe, isLibraryFrame }) => {
   const FileDetail = isLibraryFrame
     ? LibraryFrameFileDetail
     : AppFrameFileDetail;
-  const lineNumber = stackframe.line.number;
+  const lineNumber = stackframe.line?.number ?? 0;
 
   const name =
     'filename' in stackframe ? stackframe.filename : stackframe.classname;
@@ -46,7 +46,7 @@ const FrameHeading: React.FC<Props> = ({ stackframe, isLibraryFrame }) => {
       {lineNumber > 0 && (
         <Fragment>
           {' at '}
-          <FileDetail>line {stackframe.line.number}</FileDetail>
+          <FileDetail>line {lineNumber}</FileDetail>
         </Fragment>
       )}
     </FileDetails>
diff --git a/x-pack/legacy/plugins/apm/public/components/shared/Stacktrace/Stackframe.tsx b/x-pack/legacy/plugins/apm/public/components/shared/Stacktrace/Stackframe.tsx
@@ -77,5 +77,5 @@ export function Stackframe({
 function hasLineContext(
   stackframe: IStackframe
 ): stackframe is IStackframeWithLineContext {
-  return stackframe.line.hasOwnProperty('context');
+  return stackframe.line?.hasOwnProperty('context') || false;
 }
diff --git a/x-pack/legacy/plugins/apm/typings/es_schemas/raw/fields/Stackframe.ts b/x-pack/legacy/plugins/apm/typings/es_schemas/raw/fields/Stackframe.ts
@@ -15,7 +15,7 @@ type IStackframeBase = {
   vars?: {
     [key: string]: unknown;
   };
-  line: {
+  line?: {
     number: number;
   };
 } & ({ classname: string } | { filename: string });

Original file line number	Diff line number	Diff line change
`@@ -77,5 +77,5 @@ export function Stackframe({`
`77`	`77`	`function hasLineContext(`
`78`	`78`	`stackframe: IStackframe`
`79`	`79`	`): stackframe is IStackframeWithLineContext {`
`80`		`- return stackframe.line.hasOwnProperty('context');`
	`80`	`+ return stackframe.line?.hasOwnProperty('context') \|\| false;`
`81`	`81`	`}`