Skip to content

Commit c8d99ed

Browse files
authored
Merge branch 'main' into init-streams-plugin
2 parents 2ad08f4 + 9975c55 commit c8d99ed

7 files changed

Lines changed: 64 additions & 61 deletions

File tree

x-pack/plugins/observability_solution/infra/common/ui_settings.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,13 @@ export const uiSettings: Record<string, UiSettingsParams> = {
2323
description: i18n.translate('xpack.infra.enableLogsStreamDescription', {
2424
defaultMessage: 'Enables the legacy Logs Stream application and dashboard panel. ',
2525
}),
26+
deprecation: {
27+
message: i18n.translate('xpack.infra.enableLogsStreamDeprecationWarning', {
28+
defaultMessage:
29+
'Logs Stream is deprecated, and this setting will be removed in Kibana 9.0.',
30+
}),
31+
docLinksKey: 'generalSettings',
32+
},
2633
type: 'boolean',
2734
schema: schema.boolean(),
2835
requiresPageReload: true,

x-pack/plugins/observability_solution/infra/public/components/logs_deprecation_callout.tsx

Lines changed: 14 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -9,36 +9,28 @@ import { EuiCallOut } from '@elastic/eui';
99
import React from 'react';
1010
import { i18n } from '@kbn/i18n';
1111
import { EuiButton } from '@elastic/eui';
12-
import {
13-
AllDatasetsLocatorParams,
14-
ALL_DATASETS_LOCATOR_ID,
15-
DatasetLocatorParams,
16-
} from '@kbn/deeplinks-observability';
1712
import { getRouterLinkProps } from '@kbn/router-utils';
1813
import useLocalStorage from 'react-use/lib/useLocalStorage';
19-
2014
import { euiThemeVars } from '@kbn/ui-theme';
2115
import { css } from '@emotion/css';
2216
import { LocatorPublic } from '@kbn/share-plugin/common';
17+
import { DISCOVER_APP_LOCATOR, DiscoverAppLocatorParams } from '@kbn/discover-plugin/common';
2318
import { useKibanaContextForPlugin } from '../hooks/use_kibana';
2419

2520
const pageConfigurations = {
2621
stream: {
2722
dismissalStorageKey: 'log_stream_deprecation_callout_dismissed',
28-
message: i18n.translate('xpack.infra.logsDeprecationCallout.p.theNewLogsExplorerLabel', {
23+
message: i18n.translate('xpack.infra.logsDeprecationCallout.stream.exploreWithDiscover', {
2924
defaultMessage:
30-
'The new Logs Explorer makes viewing and inspecting your logs easier with more features, better performance, and more intuitive navigation. We recommend switching to Logs Explorer, as it will replace Logs Stream in a future version.',
25+
'Logs Stream and Logs Explorer are set to be deprecated. Switch to Discover which now includes their functionality plus more features, better performance, and more intuitive navigation. ',
3126
}),
3227
},
3328
settings: {
3429
dismissalStorageKey: 'log_settings_deprecation_callout_dismissed',
35-
message: i18n.translate(
36-
'xpack.infra.logsSettingsDeprecationCallout.p.theNewLogsExplorerLabel',
37-
{
38-
defaultMessage:
39-
'These settings only apply to the legacy Logs Stream app, and we do not recommend configuring them. Instead, use Logs Explorer which makes viewing and inspecting your logs easier with more features, better performance, and more intuitive navigation.',
40-
}
41-
),
30+
message: i18n.translate('xpack.infra.logsDeprecationCallout.settings.exploreWithDiscover', {
31+
defaultMessage:
32+
'These settings only apply to the legacy Logs Stream app. Switch to Discover for the same functionality plus more features, better performance, and more intuitive navigation.',
33+
}),
4234
},
4335
};
4436

@@ -60,10 +52,9 @@ export const LogsDeprecationCallout = ({ page }: LogsDeprecationCalloutProps) =>
6052

6153
const [isDismissed, setDismissed] = useLocalStorage(dismissalStorageKey, false);
6254

63-
const allDatasetLocator =
64-
share.url.locators.get<AllDatasetsLocatorParams>(ALL_DATASETS_LOCATOR_ID);
55+
const discoverLocator = share.url.locators.get<DiscoverAppLocatorParams>(DISCOVER_APP_LOCATOR);
6556

66-
if (isDismissed || !(allDatasetLocator && discover?.show && fleet?.read)) {
57+
if (isDismissed || !(discoverLocator && discover?.show && fleet?.read)) {
6758
return null;
6859
}
6960

@@ -81,19 +72,19 @@ export const LogsDeprecationCallout = ({ page }: LogsDeprecationCalloutProps) =>
8172
<p>{message}</p>
8273
<EuiButton
8374
fill
84-
data-test-subj="infraLogsDeprecationCalloutTryLogsExplorerButton"
75+
data-test-subj="infraLogsDeprecationCalloutGoToDiscoverButton"
8576
color="warning"
86-
{...getLogsExplorerLinkProps(allDatasetLocator)}
77+
{...getDiscoverLinkProps(discoverLocator)}
8778
>
88-
{i18n.translate('xpack.infra.logsDeprecationCallout.tryLogsExplorerButtonLabel', {
89-
defaultMessage: 'Try Logs Explorer',
79+
{i18n.translate('xpack.infra.logsDeprecationCallout.goToDiscoverButtonLabel', {
80+
defaultMessage: 'Go to Discover',
9081
})}
9182
</EuiButton>
9283
</EuiCallOut>
9384
);
9485
};
9586

96-
const getLogsExplorerLinkProps = (locator: LocatorPublic<DatasetLocatorParams>) => {
87+
const getDiscoverLinkProps = (locator: LocatorPublic<DiscoverAppLocatorParams>) => {
9788
return getRouterLinkProps({
9889
href: locator.getRedirectUrl({}),
9990
onClick: () => locator.navigate({}),

x-pack/plugins/observability_solution/observability_logs_explorer/common/translations.ts

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,14 +22,26 @@ export const observabilityAppTitle = i18n.translate(
2222
}
2323
);
2424

25-
export const betaBadgeTitle = i18n.translate('xpack.observabilityLogsExplorer.betaBadgeTitle', {
26-
defaultMessage: 'Beta',
27-
});
25+
export const deprecationBadgeTitle = i18n.translate(
26+
'xpack.observabilityLogsExplorer.deprecationBadgeTitle',
27+
{
28+
defaultMessage: 'Deprecation notice',
29+
}
30+
);
31+
32+
export const deprecationBadgeDescription = i18n.translate(
33+
'xpack.observabilityLogsExplorer.deprecationBadgeDescription',
34+
{
35+
defaultMessage:
36+
'Logs Stream and Logs Explorer are set to be deprecated. Switch to Discover which now includes their functionality plus more features and better performance.',
37+
}
38+
);
2839

29-
export const betaBadgeDescription = i18n.translate(
30-
'xpack.observabilityLogsExplorer.betaBadgeDescription',
40+
export const deprecationBadgeGuideline = i18n.translate(
41+
'xpack.observabilityLogsExplorer.deprecationBadgeGuideline',
3142
{
32-
defaultMessage: 'This application is in beta and therefore subject to change.',
43+
defaultMessage:
44+
'You can temporarily access Logs Stream by re-enabling it in Advanced Settings.',
3345
}
3446
);
3547

x-pack/plugins/observability_solution/observability_logs_explorer/public/components/logs_explorer_top_nav_menu.tsx

Lines changed: 25 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,11 @@ import { LogsExplorerTabs } from '@kbn/discover-plugin/public';
2121
import React, { useEffect, useState } from 'react';
2222
import useObservable from 'react-use/lib/useObservable';
2323
import { filter, take } from 'rxjs';
24-
import { betaBadgeDescription, betaBadgeTitle } from '../../common/translations';
24+
import {
25+
deprecationBadgeDescription,
26+
deprecationBadgeGuideline,
27+
deprecationBadgeTitle,
28+
} from '../../common/translations';
2529
import { useKibanaContextForPlugin } from '../utils/use_kibana';
2630
import { ConnectedDiscoverLink } from './discover_link';
2731
import { FeedbackLink } from './feedback_link';
@@ -59,13 +63,7 @@ const ProjectTopNav = () => {
5963
`}
6064
>
6165
<EuiHeaderSectionItem>
62-
<EuiBetaBadge
63-
size="s"
64-
iconType="beta"
65-
label={betaBadgeTitle}
66-
tooltipContent={betaBadgeDescription}
67-
alignment="middle"
68-
/>
66+
<DeprecationNoticeBadge />
6967
</EuiHeaderSectionItem>
7068
<EuiHeaderSectionItem>
7169
<EuiHeaderLinks gutterSize="xs">
@@ -115,15 +113,6 @@ const ClassicTopNav = () => {
115113
margin-left: ${euiThemeVars.euiSizeM};
116114
`}
117115
>
118-
<EuiHeaderSectionItem>
119-
<EuiBetaBadge
120-
size="s"
121-
iconType="beta"
122-
label={betaBadgeTitle}
123-
tooltipContent={betaBadgeDescription}
124-
alignment="middle"
125-
/>
126-
</EuiHeaderSectionItem>
127116
<EuiHeaderSectionItem>
128117
<FeedbackLink />
129118
</EuiHeaderSectionItem>
@@ -145,6 +134,9 @@ const ClassicTopNav = () => {
145134
<EuiHeaderSection data-test-subj="logsExplorerHeaderMenu">
146135
<EuiHeaderSectionItem>
147136
<EuiHeaderLinks gutterSize="xs">
137+
<EuiHeaderSectionItem>
138+
<DeprecationNoticeBadge />
139+
</EuiHeaderSectionItem>
148140
<ConnectedDiscoverLink />
149141
<ConditionalVerticalRule Component={ConnectedDatasetQualityLink()} />
150142
<VerticalRule />
@@ -171,3 +163,19 @@ const ConditionalVerticalRule = ({ Component }: { Component: JSX.Element | null
171163
{Component}
172164
</>
173165
);
166+
167+
const DeprecationNoticeBadge = () => (
168+
<EuiBetaBadge
169+
label={deprecationBadgeTitle}
170+
color="subdued"
171+
tooltipContent={
172+
<>
173+
{deprecationBadgeDescription}
174+
<br />
175+
<br />
176+
{deprecationBadgeGuideline}
177+
</>
178+
}
179+
alignment="middle"
180+
/>
181+
);

x-pack/plugins/translations/translations/fr-FR.json

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24651,8 +24651,6 @@
2465124651
"xpack.infra.logs.viewInContext.logsFromContainerTitle": "Les logs affichés proviennent du conteneur {container}",
2465224652
"xpack.infra.logs.viewInContext.logsFromFileTitle": "Les logs affichés proviennent du fichier {file} et de l'hôte {host}",
2465324653
"xpack.infra.logsDeprecationCallout.euiCallOut.discoverANewLogLabel": "Il existe une nouvelle (et meilleure) façon d'explorer vos logs !",
24654-
"xpack.infra.logsDeprecationCallout.p.theNewLogsExplorerLabel": "Le nouveau Logs Explorer facilite la visualisation et l'inspection de vos journaux et propose davantage de fonctionnalités, des performances supérieures ainsi qu’une navigation plus intuitive. Nous vous recommandons de passer à Logs Explorer, car il remplacera Logs Stream dans une version ultérieure.",
24655-
"xpack.infra.logsDeprecationCallout.tryLogsExplorerButtonLabel": "Essayer Logs Explorer",
2465624654
"xpack.infra.logsHeaderAddDataButtonLabel": "Ajouter des données",
2465724655
"xpack.infra.logSourceConfiguration.childFormElementErrorMessage": "L'état d'au moins un champ du formulaire est non valide.",
2465824656
"xpack.infra.logSourceConfiguration.dataViewDescription": "Vue de données contenant les données de log",
@@ -24685,7 +24683,6 @@
2468524683
"xpack.infra.logSourceErrorPage.tryAgainButtonLabel": "Réessayer",
2468624684
"xpack.infra.logsPage.toolbar.kqlSearchFieldPlaceholder": "Recherche d'entrées de log… (par ex. host.name:host-1)",
2468724685
"xpack.infra.logsPage.toolbar.logFilterErrorToastTitle": "Erreur de filtrage du log",
24688-
"xpack.infra.logsSettingsDeprecationCallout.p.theNewLogsExplorerLabel": "Ces paramètres s'appliquent uniquement à l'ancienne application Logs Stream et nous vous déconseillons de les configurer. Utilisez plutôt le nouveau Logs Explorer qui facilite la visualisation et l'inspection de vos logs et propose davantage de fonctionnalités, des performances supérieures ainsi qu'une navigation plus intuitive.",
2468924686
"xpack.infra.logsSettingsPage.loadingButtonLabel": "Chargement",
2469024687
"xpack.infra.logsStreamEmbeddable.deprecationWarningDescription": "La maintenance des panneaux de flux de logs n'est plus assurée. Essayez d'utiliser {savedSearchDocsLink} pour une visualisation similaire.",
2469124688
"xpack.infra.logsStreamEmbeddable.deprecationWarningDescription.savedSearchesLinkLabel": "recherches enregistrées",
@@ -34658,8 +34655,6 @@
3465834655
"xpack.observabilityLogsExplorer.alertsPopover.createSLOMenuItem": "Créer un SLO",
3465934656
"xpack.observabilityLogsExplorer.alertsPopover.manageRulesMenuItem": "{canCreateRule, select, true{Gérer} other{Afficher}} les règles",
3466034657
"xpack.observabilityLogsExplorer.appTitle": "Explorateur de logs",
34661-
"xpack.observabilityLogsExplorer.betaBadgeDescription": "Il s'agit du stade bêta de l'application, qui est donc susceptible d'évoluer.",
34662-
"xpack.observabilityLogsExplorer.betaBadgeTitle": "Bêta",
3466334658
"xpack.observabilityLogsExplorer.createSlo": "Créer un SLO",
3466434659
"xpack.observabilityLogsExplorer.datasetQualityLinkTitle": "Ensembles de données",
3466534660
"xpack.observabilityLogsExplorer.discoverLinkTitle": "Ouvrir dans Discover",

x-pack/plugins/translations/translations/ja-JP.json

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24625,8 +24625,6 @@
2462524625
"xpack.infra.logs.viewInContext.logsFromContainerTitle": "表示されたログはコンテナー{container}から取得されました",
2462624626
"xpack.infra.logs.viewInContext.logsFromFileTitle": "表示されたログは、ファイル{file}およびホスト{host}から取得されました",
2462724627
"xpack.infra.logsDeprecationCallout.euiCallOut.discoverANewLogLabel": "ログの探索には、新しく、もっと効果的な方法があります。",
24628-
"xpack.infra.logsDeprecationCallout.p.theNewLogsExplorerLabel": "新しいログエクスプローラーには、追加機能、パフォーマンスの改善、さらに直感的なナビゲーションが導入され、ログの表示と調査がさらに簡単になりました。将来のバージョンでは、ログストリームに取って代わるため、ログエクスプローラーを使用することをお勧めします。",
24629-
"xpack.infra.logsDeprecationCallout.tryLogsExplorerButtonLabel": "ログエクスプローラーを試す",
2463024628
"xpack.infra.logsHeaderAddDataButtonLabel": "データの追加",
2463124629
"xpack.infra.logSourceConfiguration.childFormElementErrorMessage": "1つ以上のフォームフィールドが無効な状態です。",
2463224630
"xpack.infra.logSourceConfiguration.dataViewDescription": "ログデータを含むデータビュー",
@@ -24658,7 +24656,6 @@
2465824656
"xpack.infra.logSourceErrorPage.tryAgainButtonLabel": "再試行",
2465924657
"xpack.infra.logsPage.toolbar.kqlSearchFieldPlaceholder": "ログエントリーを検索中…(例:host.name:host-1)",
2466024658
"xpack.infra.logsPage.toolbar.logFilterErrorToastTitle": "ログフィルターエラー",
24661-
"xpack.infra.logsSettingsDeprecationCallout.p.theNewLogsExplorerLabel": "これらの設定はレガシーログストリームアプリにのみ適用されます。これらを構成することはお勧めしません。代わりに、新しいログエクスプローラーを使用してください。追加機能、パフォーマンスの改善、さらに直感的なナビゲーションが導入され、ログの表示と調査がさらに簡単になりました。",
2466224659
"xpack.infra.logsSettingsPage.loadingButtonLabel": "読み込み中",
2466324660
"xpack.infra.logsStreamEmbeddable.deprecationWarningDescription": "ログストリームパネルは管理されていません。{savedSearchDocsLink}を同様の視覚化に活用してください。",
2466424661
"xpack.infra.logsStreamEmbeddable.deprecationWarningDescription.savedSearchesLinkLabel": "保存された検索",
@@ -34628,8 +34625,6 @@
3462834625
"xpack.observabilityLogsExplorer.alertsPopover.createSLOMenuItem": "SLOの作成",
3462934626
"xpack.observabilityLogsExplorer.alertsPopover.manageRulesMenuItem": "ルールを{canCreateRule, select, true{管理} other{表示}}",
3463034627
"xpack.observabilityLogsExplorer.appTitle": "ログエクスプローラー",
34631-
"xpack.observabilityLogsExplorer.betaBadgeDescription": "このアプリケーションはベータ版であるため、変更される場合があります。",
34632-
"xpack.observabilityLogsExplorer.betaBadgeTitle": "ベータ",
3463334628
"xpack.observabilityLogsExplorer.createSlo": "SLOの作成",
3463434629
"xpack.observabilityLogsExplorer.datasetQualityLinkTitle": "データセット",
3463534630
"xpack.observabilityLogsExplorer.discoverLinkTitle": "Discoverで開く",

x-pack/plugins/translations/translations/zh-CN.json

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24204,8 +24204,6 @@
2420424204
"xpack.infra.logs.viewInContext.logsFromContainerTitle": "显示的日志来自容器 {container}",
2420524205
"xpack.infra.logs.viewInContext.logsFromFileTitle": "显示的日志来自文件 {file} 和主机 {host}",
2420624206
"xpack.infra.logsDeprecationCallout.euiCallOut.discoverANewLogLabel": "这是浏览日志的更有效的新方法!",
24207-
"xpack.infra.logsDeprecationCallout.p.theNewLogsExplorerLabel": "新的日志浏览器具有更多功能,更优异的性能和更直观的导航,便于您更轻松地查看和检查日志。建议您切换到日志浏览器,因为它将在未来版本中替代日志流。",
24208-
"xpack.infra.logsDeprecationCallout.tryLogsExplorerButtonLabel": "试用日志浏览器",
2420924207
"xpack.infra.logsHeaderAddDataButtonLabel": "添加数据",
2421024208
"xpack.infra.logSourceConfiguration.childFormElementErrorMessage": "至少一个表单字段处于无效状态。",
2421124209
"xpack.infra.logSourceConfiguration.dataViewDescription": "包含日志数据的数据视图",
@@ -24236,7 +24234,6 @@
2423624234
"xpack.infra.logSourceErrorPage.tryAgainButtonLabel": "重试",
2423724235
"xpack.infra.logsPage.toolbar.kqlSearchFieldPlaceholder": "搜索日志条目……(例如 host.name:host-1)",
2423824236
"xpack.infra.logsPage.toolbar.logFilterErrorToastTitle": "日志筛选错误",
24239-
"xpack.infra.logsSettingsDeprecationCallout.p.theNewLogsExplorerLabel": "这些设置仅适用于旧版日志流应用,不建议配置它们。相反,应使用具有更多功能,更优异的性能和更直观的导航,便于您更轻松地查看和检查日志的日志浏览器。",
2424024237
"xpack.infra.logsSettingsPage.loadingButtonLabel": "正在加载",
2424124238
"xpack.infra.logsStreamEmbeddable.deprecationWarningDescription": "将不再维护日志流面板。尝试将 {savedSearchDocsLink} 用于类似可视化。",
2424224239
"xpack.infra.logsStreamEmbeddable.deprecationWarningDescription.savedSearchesLinkLabel": "已保存的搜索",
@@ -34107,8 +34104,6 @@
3410734104
"xpack.observabilityLogsExplorer.alertsPopover.createSLOMenuItem": "创建 SLO",
3410834105
"xpack.observabilityLogsExplorer.alertsPopover.manageRulesMenuItem": "{canCreateRule, select, true{管理} other{查看}}规则",
3410934106
"xpack.observabilityLogsExplorer.appTitle": "日志浏览器",
34110-
"xpack.observabilityLogsExplorer.betaBadgeDescription": "此应用程序为公测版,因此可能会进行更改。",
34111-
"xpack.observabilityLogsExplorer.betaBadgeTitle": "公测版",
3411234107
"xpack.observabilityLogsExplorer.createSlo": "创建 SLO",
3411334108
"xpack.observabilityLogsExplorer.datasetQualityLinkTitle": "数据集",
3411434109
"xpack.observabilityLogsExplorer.discoverLinkTitle": "在 Discover 中打开",

0 commit comments

Comments
 (0)