Skip to content

Commit c6fedca

Browse files
[8.x] style(ux-dashboards): fixed width from saved object type column (#194388) (#196952)
# Backport This will backport the following commits from `main` to `8.x`: - [style(ux-dashboards): fixed width from saved object type column (#194388)](#194388) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"ruby","email":"ruichao.hu@daocloud.io"},"sourceCommit":{"committedDate":"2024-10-18T19:54:35Z","message":"style(ux-dashboards): fixed width from saved object type column (#194388)\n\n## Summary\r\nFixes https://github.com/elastic/kibana/issues/193750\r\n\r\nRemoved the fixed width of 50px from the type column in the saved object\r\nfinder UI to allow for more flexible and responsive table formatting.\r\n\r\nBefore:\r\n\r\n![image](https://github.com/user-attachments/assets/df4d312c-8956-482e-a91e-643831e7364e)\r\n\r\nNow:\r\n\r\n![image](https://github.com/user-attachments/assets/987f37e6-b14e-41c5-a435-ce2539936c7c)\r\n\r\n\r\nBut I'm not sure if changing the width to 70px is more appropriate\r\n\r\n\r\n![image](https://github.com/user-attachments/assets/f6a52146-bc7a-4d65-b86c-a7c1393c88f5)\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>\r\nCo-authored-by: Davis McPhee <davis.mcphee@elastic.co>","sha":"febb198a8ab7b4407d72d881b319c84ed73ee5d3","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","💝community","v9.0.0","Team:DataDiscovery","backport:prev-major"],"title":"style(ux-dashboards): fixed width from saved object type column","number":194388,"url":"https://github.com/elastic/kibana/pull/194388","mergeCommit":{"message":"style(ux-dashboards): fixed width from saved object type column (#194388)\n\n## Summary\r\nFixes https://github.com/elastic/kibana/issues/193750\r\n\r\nRemoved the fixed width of 50px from the type column in the saved object\r\nfinder UI to allow for more flexible and responsive table formatting.\r\n\r\nBefore:\r\n\r\n![image](https://github.com/user-attachments/assets/df4d312c-8956-482e-a91e-643831e7364e)\r\n\r\nNow:\r\n\r\n![image](https://github.com/user-attachments/assets/987f37e6-b14e-41c5-a435-ce2539936c7c)\r\n\r\n\r\nBut I'm not sure if changing the width to 70px is more appropriate\r\n\r\n\r\n![image](https://github.com/user-attachments/assets/f6a52146-bc7a-4d65-b86c-a7c1393c88f5)\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>\r\nCo-authored-by: Davis McPhee <davis.mcphee@elastic.co>","sha":"febb198a8ab7b4407d72d881b319c84ed73ee5d3"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194388","number":194388,"mergeCommit":{"message":"style(ux-dashboards): fixed width from saved object type column (#194388)\n\n## Summary\r\nFixes https://github.com/elastic/kibana/issues/193750\r\n\r\nRemoved the fixed width of 50px from the type column in the saved object\r\nfinder UI to allow for more flexible and responsive table formatting.\r\n\r\nBefore:\r\n\r\n![image](https://github.com/user-attachments/assets/df4d312c-8956-482e-a91e-643831e7364e)\r\n\r\nNow:\r\n\r\n![image](https://github.com/user-attachments/assets/987f37e6-b14e-41c5-a435-ce2539936c7c)\r\n\r\n\r\nBut I'm not sure if changing the width to 70px is more appropriate\r\n\r\n\r\n![image](https://github.com/user-attachments/assets/f6a52146-bc7a-4d65-b86c-a7c1393c88f5)\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>\r\nCo-authored-by: Davis McPhee <davis.mcphee@elastic.co>","sha":"febb198a8ab7b4407d72d881b319c84ed73ee5d3"}}]}] BACKPORT--> Co-authored-by: ruby <ruichao.hu@daocloud.io>
1 parent 2e05118 commit c6fedca

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

src/plugins/saved_objects_finder/public/finder/saved_object_finder.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,7 @@ export class SavedObjectFinderUi extends React.Component<
231231
name: i18n.translate('savedObjectsFinder.typeName', {
232232
defaultMessage: 'Type',
233233
}),
234-
width: '50px',
234+
width: '70px',
235235
align: 'center',
236236
description: i18n.translate('savedObjectsFinder.typeDescription', {
237237
defaultMessage: 'Type of the saved object',

0 commit comments

Comments
 (0)