[Maps] fix application state filters transfer from other kibana application to maps application (#73516)

nreese · elasticmachine · web-flow · commit c09216b6698e · 2020-07-30T10:30:57.000-06:00
* [Maps] fix application state filters transfer from other kibana application to maps application

* clean up comment

Co-authored-by: Elastic Machine &lt;elasticmachine@users.noreply.github.com&gt;
diff --git a/x-pack/plugins/maps/public/routing/routes/maps_app/maps_app_view.js b/x-pack/plugins/maps/public/routing/routes/maps_app/maps_app_view.js
@@ -91,14 +91,6 @@ export class MapsAppView extends React.Component {
       this._globalSyncChangeMonitorSubscription.unsubscribe();
     }
 
-    // Clean up app state filters
-    const { filterManager } = getData().query;
-    filterManager.filters.forEach((filter) => {
-      if (filter.$state.store === esFilters.FilterStateStore.APP_STATE) {
-        filterManager.removeFilter(filter);
-      }
-    });
-
     getCoreChrome().setBreadcrumbs([]);
   }
 
diff --git a/x-pack/plugins/maps/public/routing/state_syncing/app_sync.js b/x-pack/plugins/maps/public/routing/state_syncing/app_sync.js
@@ -15,6 +15,10 @@ export function startAppStateSyncing(appStateManager) {
   // sync app filters with app state container from data.query to state container
   const { query } = getData();
 
+  // Filter manager state persists across applications
+  // clear app state filters to prevent application filters from other applications being transfered to maps
+  query.filterManager.setAppFilters([]);
+
   const stateContainer = {
     get: () => ({
       query: appStateManager.getQuery(),

Original file line number	Diff line number	Diff line change
`@@ -91,14 +91,6 @@ export class MapsAppView extends React.Component {`
`91`	`91`	`this._globalSyncChangeMonitorSubscription.unsubscribe();`
`92`	`92`	`}`
`93`	`93`
`94`		`- // Clean up app state filters`
`95`		`- const { filterManager } = getData().query;`
`96`		`- filterManager.filters.forEach((filter) => {`
`97`		`- if (filter.$state.store === esFilters.FilterStateStore.APP_STATE) {`
`98`		`- filterManager.removeFilter(filter);`
`99`		`- }`
`100`		`- });`
`101`		`-`
`102`	`94`	`getCoreChrome().setBreadcrumbs([]);`
`103`	`95`	`}`
`104`	`96`