[chore] Enable core's eslint rule: @ts-expect-error (#93086)

afharo · web-flow · commit c0535abc06f6 · 2021-03-02T05:53:36.000-05:00
* [chore] Enable core's eslint rules

* Change comment from platform-team to core-team
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -1316,7 +1316,7 @@ module.exports = {
 
     {
       files: [
-        // platform-team owned code
+        // core-team owned code
         'src/core/**',
         'x-pack/plugins/features/**',
         'x-pack/plugins/licensing/**',
@@ -1325,6 +1325,14 @@ module.exports = {
         'packages/kbn-config-schema',
         'src/plugins/status_page/**',
         'src/plugins/saved_objects_management/**',
+        'packages/kbn-analytics/**',
+        'packages/kbn-telemetry-tools/**',
+        'src/plugins/kibana_usage_collection/**',
+        'src/plugins/usage_collection/**',
+        'src/plugins/telemetry/**',
+        'src/plugins/telemetry_collection_manager/**',
+        'src/plugins/telemetry_management_section/**',
+        'x-pack/plugins/telemetry_collection_xpack/**',
       ],
       rules: {
         '@typescript-eslint/prefer-ts-expect-error': 'error',
diff --git a/src/plugins/kibana_usage_collection/server/collectors/kibana/get_saved_object_counts.test.ts b/src/plugins/kibana_usage_collection/server/collectors/kibana/get_saved_object_counts.test.ts
@@ -12,7 +12,7 @@ import { getSavedObjectsCounts } from './get_saved_object_counts';
 export function mockGetSavedObjectsCounts(params: any) {
   const esClient = elasticsearchServiceMock.createClusterClient().asInternalUser;
   esClient.search.mockResolvedValue(
-    // @ts-ignore we only care about the response body
+    // @ts-expect-error we only care about the response body
     {
       body: { ...params },
     }
diff --git a/src/plugins/telemetry/public/services/telemetry_sender.test.ts b/src/plugins/telemetry/public/services/telemetry_sender.test.ts
@@ -126,9 +126,7 @@ describe('TelemetrySender', () => {
         originalFetch = window.fetch;
       });
 
-      // @ts-ignore
       beforeEach(() => (window.fetch = mockFetch = jest.fn()));
-      // @ts-ignore
       afterAll(() => (window.fetch = originalFetch));
 
       it('does not send if already sending', async () => {
@@ -250,9 +248,7 @@ describe('TelemetrySender', () => {
       originalSetInterval = window.setInterval;
     });
 
-    // @ts-ignore
     beforeEach(() => (window.setInterval = mockSetInterval = jest.fn()));
-    // @ts-ignore
     afterAll(() => (window.setInterval = originalSetInterval));
 
     it('calls sendIfDue every 60000 ms', () => {
diff --git a/src/plugins/telemetry/public/services/telemetry_service.test.ts b/src/plugins/telemetry/public/services/telemetry_service.test.ts
@@ -211,9 +211,7 @@ describe('TelemetryService', () => {
       originalFetch = window.fetch;
     });
 
-    // @ts-ignore
     beforeEach(() => (window.fetch = mockFetch = jest.fn()));
-    // @ts-ignore
     afterAll(() => (window.fetch = originalFetch));
 
     it('reports opt-in status to telemetry url', async () => {
diff --git a/src/plugins/telemetry/server/fetcher.ts b/src/plugins/telemetry/server/fetcher.ts
@@ -8,7 +8,6 @@
 
 import { Observable, Subscription, timer } from 'rxjs';
 import { take } from 'rxjs/operators';
-// @ts-ignore
 import fetch from 'node-fetch';
 import {
   TelemetryCollectionManagerPluginStart,
diff --git a/src/plugins/telemetry/server/routes/telemetry_opt_in_stats.test.ts b/src/plugins/telemetry/server/routes/telemetry_opt_in_stats.test.ts
@@ -7,7 +7,6 @@
  */
 
 jest.mock('node-fetch');
-// @ts-ignore
 import fetch from 'node-fetch';
 import { sendTelemetryOptInStatus } from './telemetry_opt_in_stats';
 import { StatsGetterConfig } from 'src/plugins/telemetry_collection_manager/server';
diff --git a/src/plugins/telemetry/server/telemetry_collection/get_cluster_info.test.ts b/src/plugins/telemetry/server/telemetry_collection/get_cluster_info.test.ts
@@ -11,14 +11,12 @@ import { getClusterInfo } from './get_cluster_info';
 
 export function mockGetClusterInfo(clusterInfo: any) {
   const esClient = elasticsearchServiceMock.createClusterClient().asInternalUser;
-  esClient.info
-    // @ts-ignore we only care about the response body
-    .mockResolvedValue(
-      // @ts-ignore we only care about the response body
-      {
-        body: { ...clusterInfo },
-      }
-    );
+  esClient.info.mockResolvedValue(
+    // @ts-expect-error we only care about the response body
+    {
+      body: { ...clusterInfo },
+    }
+  );
   return esClient;
 }
 
diff --git a/src/plugins/telemetry/server/telemetry_collection/get_cluster_stats.test.ts b/src/plugins/telemetry/server/telemetry_collection/get_cluster_stats.test.ts
@@ -21,7 +21,7 @@ describe('get_cluster_stats', () => {
     const response = Promise.resolve({ body: { cluster_uuid: '1234' } });
     const esClient = elasticsearchServiceMock.createClusterClient().asInternalUser;
     esClient.cluster.stats.mockImplementationOnce(
-      // @ts-ignore the method only cares about the response body
+      // @ts-expect-error the method only cares about the response body
       async (_params = { timeout: TIMEOUT }) => {
         return response;
       }
diff --git a/src/plugins/telemetry/server/telemetry_collection/get_data_telemetry/get_data_telemetry.test.ts b/src/plugins/telemetry/server/telemetry_collection/get_data_telemetry/get_data_telemetry.test.ts
@@ -265,7 +265,7 @@ function mockEsClient(
   indexStats: any = {}
 ) {
   const esClient = elasticsearchServiceMock.createClusterClient().asInternalUser;
-  // @ts-ignore
+  // @ts-expect-error
   esClient.indices.getMapping.mockImplementationOnce(async () => {
     const body = Object.fromEntries(
       indicesMappings.map((index) => [
@@ -294,7 +294,7 @@ function mockEsClient(
     );
     return { body };
   });
-  // @ts-ignore
+  // @ts-expect-error
   esClient.indices.stats.mockImplementationOnce(async () => {
     return { body: indexStats };
   });
diff --git a/src/plugins/telemetry/server/telemetry_collection/get_local_stats.test.ts b/src/plugins/telemetry/server/telemetry_collection/get_local_stats.test.ts
@@ -24,19 +24,17 @@ function mockUsageCollection(kibanaUsage = {}) {
 // set up successful call mocks for info, cluster stats, nodes usage and data telemetry
 function mockGetLocalStats(clusterInfo: any, clusterStats: any) {
   const esClient = elasticsearchServiceMock.createClusterClient().asInternalUser;
-  esClient.info
-    // @ts-ignore we only care about the response body
-    .mockResolvedValue(
-      // @ts-ignore we only care about the response body
-      {
-        body: { ...clusterInfo },
-      }
-    );
+  esClient.info.mockResolvedValue(
+    // @ts-expect-error we only care about the response body
+    {
+      body: { ...clusterInfo },
+    }
+  );
   esClient.cluster.stats
-    // @ts-ignore we only care about the response body
+    // @ts-expect-error we only care about the response body
     .mockResolvedValue({ body: { ...clusterStats } });
   esClient.nodes.usage.mockResolvedValue(
-    // @ts-ignore we only care about the response body
+    // @ts-expect-error we only care about the response body
     {
       body: {
         cluster_name: 'testCluster',
@@ -64,9 +62,9 @@ function mockGetLocalStats(clusterInfo: any, clusterStats: any) {
       },
     }
   );
-  // @ts-ignore we only care about the response body
+  // @ts-expect-error we only care about the response body
   esClient.indices.getMapping.mockResolvedValue({ body: { mappings: {} } });
-  // @ts-ignore we only care about the response body
+  // @ts-expect-error we only care about the response body
   esClient.indices.stats.mockResolvedValue({ body: { indices: {} } });
   return esClient;
 }
diff --git a/src/plugins/telemetry/server/telemetry_collection/get_nodes_usage.test.ts b/src/plugins/telemetry/server/telemetry_collection/get_nodes_usage.test.ts
@@ -40,7 +40,7 @@ describe('get_nodes_usage', () => {
     const response = Promise.resolve({ body: mockedNodesFetchResponse });
     const esClient = elasticsearchServiceMock.createClusterClient().asInternalUser;
     esClient.nodes.usage.mockImplementationOnce(
-      // @ts-ignore
+      // @ts-expect-error
       async (_params = { timeout: TIMEOUT }) => {
         return response;
       }
diff --git a/x-pack/plugins/telemetry_collection_xpack/server/telemetry_collection/get_stats_with_xpack.test.ts b/x-pack/plugins/telemetry_collection_xpack/server/telemetry_collection/get_stats_with_xpack.test.ts
@@ -61,22 +61,22 @@ function mockEsClient() {
   const esClient = elasticsearchServiceMock.createClusterClient().asInternalUser;
   // mock for license should return a basic license
   esClient.license.get.mockResolvedValue(
-    // @ts-ignore we only care about the response body
+    // @ts-expect-error we only care about the response body
     { body: { license: { type: 'basic' } } }
   );
   // mock for xpack usage should return an empty object
   esClient.xpack.usage.mockResolvedValue(
-    // @ts-ignore we only care about the response body
+    // @ts-expect-error we only care about the response body
     { body: {} }
   );
   // mock for nodes usage should resolve for this test
   esClient.nodes.usage.mockResolvedValue(
-    // @ts-ignore we only care about the response body
+    // @ts-expect-error we only care about the response body
     { body: { cluster_name: 'test cluster', nodes: nodesUsage } }
   );
   // mock for info should resolve for this test
   esClient.info.mockResolvedValue(
-    // @ts-ignore we only care about the response body
+    // @ts-expect-error we only care about the response body
     {
       body: {
         cluster_uuid: 'test',
diff --git a/x-pack/plugins/telemetry_collection_xpack/server/telemetry_collection/get_xpack.test.ts b/x-pack/plugins/telemetry_collection_xpack/server/telemetry_collection/get_xpack.test.ts
@@ -12,7 +12,7 @@ describe('get_xpack', () => {
   describe('getXPackUsage', () => {
     it('uses esClient to get /_xpack/usage API', async () => {
       const esClient = elasticsearchServiceMock.createClusterClient().asInternalUser;
-      // @ts-ignore we only care about the response body
+      // @ts-expect-error we only care about the response body
       esClient.xpack.usage.mockResolvedValue({ body: {} });
       const result = await getXPackUsage(esClient);
       expect(result).toEqual({});

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ import { getSavedObjectsCounts } from './get_saved_object_counts';`
`12`	`12`	`export function mockGetSavedObjectsCounts(params: any) {`
`13`	`13`	`const esClient = elasticsearchServiceMock.createClusterClient().asInternalUser;`
`14`	`14`	`esClient.search.mockResolvedValue(`
`15`		`- // @ts-ignore we only care about the response body`
	`15`	`+ // @ts-expect-error we only care about the response body`
`16`	`16`	`{`
`17`	`17`	`body: { ...params },`
`18`	`18`	`}`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ describe('get_cluster_stats', () => {`
`21`	`21`	`const response = Promise.resolve({ body: { cluster_uuid: '1234' } });`
`22`	`22`	`const esClient = elasticsearchServiceMock.createClusterClient().asInternalUser;`
`23`	`23`	`esClient.cluster.stats.mockImplementationOnce(`
`24`		`- // @ts-ignore the method only cares about the response body`
	`24`	`+ // @ts-expect-error the method only cares about the response body`
`25`	`25`	`async (_params = { timeout: TIMEOUT }) => {`
`26`	`26`	`return response;`
`27`	`27`	`}`