[build] Include x-pack example plugins when using example-plugins flag (#126931) (#127641)

kibanamachine · jbudz · web-flow · commit bef8684fbc9c · 2022-03-14T12:55:48.000-07:00
* Revert "Revert "[build] Include x-pack example plugins when using example-plugins flag (#120697)" (#125729)" This reverts commit 7b4c34e. * skip alerting_example * link to issue (cherry picked from commit 53d7456) Co-authored-by: Jonathan Budzenski <jon@elastic.co>
diff --git a/src/dev/build/tasks/build_kibana_example_plugins.ts b/src/dev/build/tasks/build_kibana_example_plugins.ts
@@ -13,17 +13,26 @@ import { exec, mkdirp, copyAll, Task } from '../lib';
 
 export const BuildKibanaExamplePlugins: Task = {
   description: 'Building distributable versions of Kibana example plugins',
-  async run(config, log, build) {
-    const examplesDir = Path.resolve(REPO_ROOT, 'examples');
+  async run(config, log) {
     const args = [
-      '../../scripts/plugin_helpers',
+      Path.resolve(REPO_ROOT, 'scripts/plugin_helpers'),
       'build',
       `--kibana-version=${config.getBuildVersion()}`,
     ];
 
-    const folders = Fs.readdirSync(examplesDir, { withFileTypes: true })
-      .filter((f) => f.isDirectory())
-      .map((f) => Path.resolve(REPO_ROOT, 'examples', f.name));
+    const getExampleFolders = (dir: string) => {
+      return Fs.readdirSync(dir, { withFileTypes: true })
+        .filter((f) => f.isDirectory())
+        .map((f) => Path.resolve(dir, f.name));
+    };
+
+    // https://github.com/elastic/kibana/issues/127338
+    const skipExamples = ['alerting_example'];
+
+    const folders = [
+      ...getExampleFolders(Path.resolve(REPO_ROOT, 'examples')),
+      ...getExampleFolders(Path.resolve(REPO_ROOT, 'x-pack/examples')),
+    ].filter((p) => !skipExamples.includes(Path.basename(p)));
 
     for (const examplePlugin of folders) {
       try {
@@ -40,8 +49,8 @@ export const BuildKibanaExamplePlugins: Task = {
 
     const pluginsDir = config.resolveFromTarget('example_plugins');
     await mkdirp(pluginsDir);
-    await copyAll(examplesDir, pluginsDir, {
-      select: ['*/build/*.zip'],
+    await copyAll(REPO_ROOT, pluginsDir, {
+      select: ['examples/*/build/*.zip', 'x-pack/examples/*/build/*.zip'],
     });
   },
 };
