Review#1: handle review comments.

azasypkin · azasypkin · commit beb87fcfec04 · 2020-06-24T08:51:15.000+02:00
diff --git a/x-pack/plugins/security/server/authentication/authenticator.test.ts b/x-pack/plugins/security/server/authentication/authenticator.test.ts
@@ -112,7 +112,7 @@ describe('Authenticator', () => {
       ).toThrowError('Provider name "__http__" is reserved.');
     });
 
-    it('properly set `loggedOut` URL.', () => {
+    it('properly sets `loggedOut` URL.', () => {
       const basicAuthenticationProviderMock = jest.requireMock('./providers/basic')
         .BasicAuthenticationProvider;
 
diff --git a/x-pack/plugins/security/server/authentication/providers/saml.test.ts b/x-pack/plugins/security/server/authentication/providers/saml.test.ts
@@ -247,7 +247,7 @@ describe('SAMLAuthenticationProvider', () => {
           { requestId: 'some-request-id', redirectURL: '', realm: 'test-realm' }
         )
       ).resolves.toEqual(
-        AuthenticationResult.redirectTo('/base-path/', {
+        AuthenticationResult.redirectTo('/mock-server-basepath/', {
           state: {
             accessToken: 'user-initiated-login-token',
             refreshToken: 'user-initiated-login-refresh-token',
diff --git a/x-pack/plugins/security/server/authentication/providers/saml.ts b/x-pack/plugins/security/server/authentication/providers/saml.ts
@@ -283,7 +283,7 @@ export class SAMLAuthenticationProvider extends BaseAuthenticationProvider {
         ? await this.performIdPInitiatedSingleLogout(request)
         : state
         ? await this.performUserInitiatedSingleLogout(state.accessToken!, state.refreshToken!)
-        : // Once Elasticsearch can consume logout response we'll be sending it here.
+        : // Once Elasticsearch can consume logout response we'll be sending it here. See https://github.com/elastic/elasticsearch/issues/40901
           null;
 
       // Having non-null `redirect` field within logout response means that IdP

Original file line number	Diff line number	Diff line change
`@@ -247,7 +247,7 @@ describe('SAMLAuthenticationProvider', () => {`
`247`	`247`	`{ requestId: 'some-request-id', redirectURL: '', realm: 'test-realm' }`
`248`	`248`	`)`
`249`	`249`	`).resolves.toEqual(`
`250`		`- AuthenticationResult.redirectTo('/base-path/', {`
	`250`	`+ AuthenticationResult.redirectTo('/mock-server-basepath/', {`
`251`	`251`	`state: {`
`252`	`252`	`accessToken: 'user-initiated-login-token',`
`253`	`253`	`refreshToken: 'user-initiated-login-refresh-token',`