fix api docs, simplify code

mattkime · mattkime · commit be3435e175f7 · 2020-04-13T18:01:00.000-05:00
diff --git a/docs/development/plugins/data/public/kibana-plugin-plugins-data-public.indexpatternfieldlist.md b/docs/development/plugins/data/public/kibana-plugin-plugins-data-public.indexpatternfieldlist.md
@@ -24,5 +24,5 @@ export declare class FieldList extends Array<Field> implements IFieldList
 |  [getByName](./kibana-plugin-plugins-data-public.indexpatternfieldlist.getbyname.md) |  | <code>(name: string) =&gt; Field &#124; undefined</code> |  |
 |  [getByType](./kibana-plugin-plugins-data-public.indexpatternfieldlist.getbytype.md) |  | <code>(type: string) =&gt; any[]</code> |  |
 |  [remove](./kibana-plugin-plugins-data-public.indexpatternfieldlist.remove.md) |  | <code>(field: IFieldType) =&gt; void</code> |  |
-|  [update](./kibana-plugin-plugins-data-public.indexpatternfieldlist.update.md) |  | <code>(field: Field) =&gt; void</code> |  |
+|  [update](./kibana-plugin-plugins-data-public.indexpatternfieldlist.update.md) |  | <code>(field: Record&lt;string, any&gt;) =&gt; void</code> |  |
 
diff --git a/docs/development/plugins/data/public/kibana-plugin-plugins-data-public.indexpatternfieldlist.update.md b/docs/development/plugins/data/public/kibana-plugin-plugins-data-public.indexpatternfieldlist.update.md
@@ -7,5 +7,5 @@
 <b>Signature:</b>
 
 ```typescript
-update: (field: Field) => void;
+update: (field: Record<string, any>) => void;
 ```
diff --git a/src/legacy/ui/public/field_editor/field_editor.js b/src/legacy/ui/public/field_editor/field_editor.js
@@ -67,8 +67,6 @@ import { FieldFormatEditor } from './components/field_format_editor';
 
 import { FIELD_TYPES_BY_LANG, DEFAULT_FIELD_TYPES } from './constants';
 import { executeScript, isScriptValid } from './lib';
-// import { copyField, executeScript, isScriptValid } from './lib';
-// import { Field } from '../../../../plugins/data/public';
 
 import { i18n } from '@kbn/i18n';
 import { FormattedMessage } from '@kbn/i18n/react';
@@ -97,11 +95,13 @@ const getFieldTypeFormatsList = (field, defaultFieldFormat) => {
   ];
 };
 
+/*
 const copyFieldMk = field => {
   // console.log('copyField', field.format.params());
   const obj = { ...field, format: field.format };
   return obj;
 };
+*/
 
 export class FieldEditor extends PureComponent {
   static propTypes = {
@@ -128,9 +128,7 @@ export class FieldEditor extends PureComponent {
       fieldTypes: [],
       fieldTypeFormats: [],
       existingFieldNames: indexPattern.fields.map(f => f.name),
-      //field: copyField(field, indexPattern),
-      //field: new Field(indexPattern, field.$$spec), // what about short dots?
-      field: copyFieldMk(field),
+      field: { ...field, format: field.format },
       fieldFormatId: undefined,
       fieldFormatParams: {},
       showScriptingHelp: false,
@@ -243,7 +241,6 @@ export class FieldEditor extends PureComponent {
   renderName() {
     const { isCreating, field } = this.state;
     const isInvalid = !field.name || !field.name.trim();
-    // console.log('renderName', this.state.field);
 
     return isCreating ? (
       <EuiFormRow
@@ -445,8 +442,6 @@ export class FieldEditor extends PureComponent {
       <FormattedMessage id="common.ui.fieldEditor.formatHeader" defaultMessage="Format" />
     );
 
-    // console.log('field_editor render fieldFormat', field.format);
-
     return (
       <Fragment>
         <EuiFormRow
diff --git a/src/legacy/ui/public/field_editor/lib/__tests__/copy_field.test.js b/src/legacy/ui/public/field_editor/lib/__tests__/copy_field.test.js
diff --git a/src/legacy/ui/public/field_editor/lib/copy_field.js b/src/legacy/ui/public/field_editor/lib/copy_field.js
diff --git a/src/plugins/data/public/public.api.md b/src/plugins/data/public/public.api.md
@@ -976,7 +976,7 @@ export class IndexPatternFieldList extends Array<IndexPatternField> implements I
     // (undocumented)
     remove: (field: IFieldType) => void;
     // (undocumented)
-    update: (field: IndexPatternField) => void;
+    update: (field: Record<string, any>) => void;
 }
 
 // Warning: (ae-missing-release-tag) "indexPatterns" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)

Original file line number	Diff line number	Diff line change
`@@ -976,7 +976,7 @@ export class IndexPatternFieldList extends Array<IndexPatternField> implements I`
`976`	`976`	`// (undocumented)`
`977`	`977`	`remove: (field: IFieldType) => void;`
`978`	`978`	`// (undocumented)`
`979`		`- update: (field: IndexPatternField) => void;`
	`979`	`+ update: (field: Record<string, any>) => void;`
`980`	`980`	`}`
`981`	`981`
`982`	`982`	`// Warning: (ae-missing-release-tag) "indexPatterns" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)`