[Maps] fix color-style disappears when mapping by percentiles when breaks are identical (#85654) (#85813)

nreese · kibanamachine · web-flow · commit bcf38e738d6f · 2020-12-14T12:29:56.000-07:00
* [Maps] fix color-style disappears when mapping by percentiles when breaks are identical

* tslint

Co-authored-by: Kibana Machine &lt;42973632+kibanamachine@users.noreply.github.com&gt;

Co-authored-by: Kibana Machine &lt;42973632+kibanamachine@users.noreply.github.com&gt;
diff --git a/x-pack/plugins/maps/public/classes/styles/vector/properties/dynamic_style_property.test.ts b/x-pack/plugins/maps/public/classes/styles/vector/properties/dynamic_style_property.test.ts
@@ -0,0 +1,47 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License;
+ * you may not use this file except in compliance with the Elastic License.
+ */
+
+import { percentilesValuesToFieldMeta } from './dynamic_style_property';
+
+describe('percentilesValuesToFieldMeta', () => {
+  test('should return null when values is not defined', () => {
+    expect(percentilesValuesToFieldMeta(undefined)).toBeNull();
+    expect(percentilesValuesToFieldMeta({})).toBeNull();
+  });
+
+  test('should convert values to percentiles field meta', () => {
+    expect(percentilesValuesToFieldMeta(undefined)).toBeNull();
+    expect(
+      percentilesValuesToFieldMeta({
+        values: {
+          '25.0': 375.0,
+          '50.0': 400.0,
+          '75.0': 550.0,
+        },
+      })
+    ).toEqual([
+      { percentile: '25.0', value: 375.0 },
+      { percentile: '50.0', value: 400.0 },
+      { percentile: '75.0', value: 550.0 },
+    ]);
+  });
+
+  test('should remove duplicated percentile percentilesValuesToFieldMeta', () => {
+    expect(percentilesValuesToFieldMeta(undefined)).toBeNull();
+    expect(
+      percentilesValuesToFieldMeta({
+        values: {
+          '25.0': 375.0,
+          '50.0': 375.0,
+          '75.0': 550.0,
+        },
+      })
+    ).toEqual([
+      { percentile: '25.0', value: 375.0 },
+      { percentile: '75.0', value: 550.0 },
+    ]);
+  });
+});
diff --git a/x-pack/plugins/maps/public/classes/styles/vector/properties/dynamic_style_property.tsx b/x-pack/plugins/maps/public/classes/styles/vector/properties/dynamic_style_property.tsx
@@ -28,6 +28,7 @@ import {
 import {
   CategoryFieldMeta,
   FieldMetaOptions,
+  PercentilesFieldMeta,
   RangeFieldMeta,
   StyleMetaData,
 } from '../../../../../common/descriptor_types';
@@ -144,15 +145,8 @@ export class DynamicStyleProperty<T>
     const styleMetaData = styleMetaDataRequest.getData() as StyleMetaData;
     const percentiles = styleMetaData[`${this._field.getRootName()}_percentiles`] as
       | undefined
-      | { values?: { [key: string]: number } };
-    return percentiles !== undefined && percentiles.values !== undefined
-      ? Object.keys(percentiles.values).map((key) => {
-          return {
-            percentile: key,
-            value: percentiles.values![key],
-          };
-        })
-      : null;
+      | PercentilesValues;
+    return percentilesValuesToFieldMeta(percentiles);
   }
 
   getCategoryFieldMeta() {
@@ -499,3 +493,21 @@ export function getNumericalMbFeatureStateValue(value: RawValue) {
   const valueAsFloat = parseFloat(value);
   return isNaN(valueAsFloat) ? null : valueAsFloat;
 }
+
+interface PercentilesValues {
+  values?: { [key: string]: number };
+}
+export function percentilesValuesToFieldMeta(
+  percentiles?: PercentilesValues | undefined
+): PercentilesFieldMeta | null {
+  if (percentiles === undefined || percentiles.values === undefined) {
+    return null;
+  }
+  const percentilesFieldMeta = Object.keys(percentiles.values).map((key) => {
+    return {
+      percentile: key,
+      value: percentiles.values![key],
+    };
+  });
+  return _.uniqBy(percentilesFieldMeta, 'value');
+}
