Review feedback

nickpeihl · nickpeihl · commit bb35a5efbbc1 · 2023-09-29T08:59:52.000-04:00
diff --git a/src/plugins/links/common/content_management/cm_services.ts b/src/plugins/links/common/content_management/cm_services.ts
@@ -11,7 +11,7 @@ import type {
   Version,
 } from '@kbn/object-versioning';
 
-// We export the versioned service definition from this file and not the barrel to avoid adding
+// We export the versioned service definition from this file and not the index file to avoid adding
 // the schemas in the "public" js bundle
 
 import { serviceDefinition as v1 } from './v1/cm_services';
diff --git a/src/plugins/links/common/types.ts b/src/plugins/links/common/types.ts
@@ -7,10 +7,10 @@
  */
 
 import type { SavedObjectsResolveResponse } from '@kbn/core-saved-objects-api-server';
+import { CONTENT_ID } from './constants';
 
-export type LinksContentType = 'links';
+export type LinksContentType = typeof CONTENT_ID;
 
-// TODO does this type need to be versioned?
 export interface SharingSavedObjectProps {
   outcome: SavedObjectsResolveResponse['outcome'];
   aliasTargetId?: SavedObjectsResolveResponse['alias_target_id'];
diff --git a/src/plugins/links/public/embeddable/links_embeddable.tsx b/src/plugins/links/public/embeddable/links_embeddable.tsx
@@ -113,8 +113,6 @@ export class LinksEmbeddable
     const { attributes } = await this.attributeService.unwrapAttributes(this.getInput());
     if (this.isDestroyed) return;
 
-    // TODO handle metaInfo
-
     this.dispatch.setAttributes(attributes);
 
     await this.initializeOutput();
