applied feedback and fixed failing cypress issue

yctercero · yctercero · commit ba8c8ac5bb8d · 2020-10-27T18:24:49.000-04:00
diff --git a/x-pack/plugins/security_solution/cypress/screens/alerts_detection_rules.ts b/x-pack/plugins/security_solution/cypress/screens/alerts_detection_rules.ts
@@ -47,9 +47,9 @@ export const RULE_CHECKBOX = '.euiTableRow .euiCheckbox__input';
 
 export const RULE_NAME = '[data-test-subj="ruleName"]';
 
-export const RULE_SWITCH = '[data-test-subj="rule-switch"]';
+export const RULE_SWITCH = '[data-test-subj="ruleSwitch"]';
 
-export const RULE_SWITCH_LOADER = '[data-test-subj="rule-switch-loader"]';
+export const RULE_SWITCH_LOADER = '[data-test-subj="ruleSwitchLoader"]';
 
 export const RULES_TABLE = '[data-test-subj="rules-table"]';
 
diff --git a/x-pack/plugins/security_solution/server/lib/detection_engine/routes/rules/validate.test.ts b/x-pack/plugins/security_solution/server/lib/detection_engine/routes/rules/validate.test.ts
@@ -110,12 +110,18 @@ describe('validate', () => {
         total: 0,
       };
       const [validated, errors] = transformValidateFindAlerts(findResult, []);
-      expect(validated).toEqual({
+      const expected: {
+        page: number;
+        perPage: number;
+        total: number;
+        data: Array<Partial<RulesSchema>>;
+      } | null = {
         data: [ruleOutput()],
         page: 1,
         perPage: 0,
         total: 0,
-      });
+      };
+      expect(validated).toEqual(expected);
       expect(errors).toEqual(null);
     });
 
@@ -160,13 +166,14 @@ describe('validate', () => {
       const ruleStatus = getFindResultStatus();
       const ruleAlert = getResult();
       const validatedOrError = transformValidateBulkError('rule-1', ruleAlert, null, ruleStatus);
-      expect(validatedOrError).toEqual({
+      const expected: RulesSchema = {
         ...ruleOutput(),
         status: 'succeeded',
         status_date: '2020-02-18T15:26:49.783Z',
         last_success_at: '2020-02-18T15:26:49.783Z',
         last_success_message: 'succeeded',
-      });
+      };
+      expect(validatedOrError).toEqual(expected);
     });
 
     test('it should return error object if "alert" is not expected alert type', () => {
